Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error prefix to errored page titles #1219

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Feb 22, 2019

As part of our guidance we recommend to put error in the title,
alongside the error summary and error messages.

As part of #1160

As part of our guidance we recommend to put error in the title,
alongside the error summary and error messages.
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NickColley NickColley merged commit c9b330c into master Feb 25, 2019
@NickColley NickColley deleted the add-error-to-titles-for-pages-that-error branch February 25, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants