Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency imports from files in the core and overrides layers #1800

Closed
3 tasks done
Tracked by #2274
36degrees opened this issue May 5, 2020 · 0 comments · Fixed by #2455
Closed
3 tasks done
Tracked by #2274

Remove dependency imports from files in the core and overrides layers #1800

36degrees opened this issue May 5, 2020 · 0 comments · Fixed by #2455
Assignees
@36degrees
Labels
breaking change sass / css
Milestone
v4.0.0

Comments

@36degrees
Copy link
Contributor

36degrees commented May 5, 2020 •
edited
Loading

What

Remove the imports of the settings, helpers and tools layers from files in core and overrides.

Why

As proposed in alphagov/govuk-design-system-architecture#22, we’re making changes to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, to reduce the time it takes to compile to CSS.

Done when…

Details of breaking change

  • which users are affected: Anyone that is importing files from the core or overrides layers without first importing base.
  • the change that’s been made: The files in these layers no longer import 'base' themselves
  • changes users will have to make: Import 'base' before importing the files in core or overrides
  • impact of users not making those changes: their Sass will not compile – they will likely see the error "Undefined mixin 'govuk-exports'" or "no mixin named govuk-exports"
@36degrees 36degrees added this to the v4.0.0 milestone May 5, 2020
@36degrees 36degrees mentioned this issue May 5, 2020
Closed
36degrees added a commit that referenced this issue May 7, 2020
@36degrees
Warn if importing core, overrides w/o dependencies
f8a0a1d 
Add deprecation warnings if users import files from the core and overrides layers without first importing the settings, helpers and tools layers.

We'll remove the imports of "base" from files in these layers in 4.0[1], so this will no longer work.

[1]: #1800
36degrees added a commit that referenced this issue May 12, 2020
@36degrees
Warn if importing core, overrides w/o dependencies
db88ee4 
Add deprecation warnings if users import files from the core and overrides layers without first importing the settings, helpers and tools layers.

We'll remove the imports of "base" from files in these layers in 4.0[1], so this will no longer work.

[1]: #1800
@36degrees 36degrees mentioned this issue May 12, 2020
Merged
36degrees added a commit that referenced this issue May 12, 2020
@36degrees
Warn if importing core, overrides w/o dependencies
6c79763 
Add deprecation warnings if users import files from the core and overrides layers without first importing the settings, helpers and tools layers.

We'll remove the imports of "base" from files in these layers in 4.0[1], so this will no longer work.

[1]: #1800
36degrees added a commit that referenced this issue May 12, 2020
@36degrees
Warn if importing core, overrides w/o dependencies
7557564 
Add deprecation warnings if users import files from the core and overrides layers without first importing the settings, helpers and tools layers.

We'll remove the imports of "base" from files in these layers in 4.0[1], so this will no longer work.

[1]: #1800
@kellylee-gds kellylee-gds mentioned this issue Sep 15, 2021
Closed
45 tasks
@36degrees 36degrees self-assigned this Dec 2, 2021
@36degrees 36degrees mentioned this issue Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
breaking change sass / css
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Remove 'base' import from files in core and overrides layers alphagov/govuk-frontend
1 participant
@36degrees