Skip to content

Commit

Permalink
Merge pull request #1672 from alphagov/add-underlines-to-footer-compo…
Browse files Browse the repository at this point in the history
…nent-links

Ensure footer links look clickable
  • Loading branch information
NickColley authored Dec 12, 2019
2 parents b0b1bf5 + a552760 commit 12f0d6c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ If you're using Nunjucks, you can now add classes to the character count compone
### Fixes

- [Pull request #1676: Fix skip link component focus style with global styles enabled](https://github.com/alphagov/govuk-frontend/pull/1676).
- [Pull request #1672: Ensure footer links look clickable](https://github.com/alphagov/govuk-frontend/pull/1672).
- [Pull request #1670: Make width-container margins more targetted to avoid specificity issues](https://github.com/alphagov/govuk-frontend/pull/1670).
- [Pull request #1655: Ensure components use public `govuk-media-query` mixin](https://github.com/alphagov/govuk-frontend/pull/1655).
- [Pull request #1648: Update checkboxes and radio buttons to include item hint classes on item hint](https://github.com/alphagov/govuk-frontend/pull/1648)
Expand Down
13 changes: 0 additions & 13 deletions src/govuk/components/footer/_footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,6 @@
}
}

// Internet Explorer 8 does not support `:not()` selectors, so don't conditionally show underlines.
@include govuk-not-ie8 {
.govuk-footer__inline-list .govuk-footer__link,
.govuk-footer__list .govuk-footer__link {
text-decoration: none;

&:hover:not(:focus),
&:active:not(:focus) {
text-decoration: underline;
}
}
}

.govuk-footer__section-break {
margin: 0; // Reset `<hr>` default margins
@include govuk-responsive-margin(8, "bottom");
Expand Down

0 comments on commit 12f0d6c

Please sign in to comment.