Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete CODEOWNERS as access managed via teams #10

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jamie-o-wilkinson
Copy link
Contributor

What problem does this pull request solve?

We currently don't need the granular control that code-owners gives, and can use access via GitHub teams for our access control requirements

Trello card: https://trello.com/c/aMbPFqoF

Things to consider when reviewing

  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@jamie-o-wilkinson jamie-o-wilkinson self-assigned this Aug 10, 2023
@jamie-o-wilkinson jamie-o-wilkinson requested a review from a team as a code owner August 10, 2023 12:34
@jamie-o-wilkinson jamie-o-wilkinson merged commit a4f69b9 into main Aug 15, 2023
@jamie-o-wilkinson jamie-o-wilkinson deleted the remove-code-owners branch August 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants