Fix navigation $from: tablet gutter offset
#3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The menu width now expands to fill the extra 30px space made available by the gutter offset Menu item “Accessibility” now fits at 768px width
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
CharlotteDowns
approved these changes
Jan 11, 2024
|
Thanks @CharlotteDowns, just going to check this with @owenatgov before we merge |
owenatgov
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
$from: tabletnavigation menu width to occupy an extra 30px spaceThe extra available width is due to our
left: -15pxgutter offset, but we didn't use itBefore
Menu item “Accessibility” doesn't fit at 768px width
After
Menu item “Accessibility” now fits at 768px width