Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the metalsmith group with 2 updates #3393

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 25, 2023

Bumps the metalsmith group with 2 updates: @metalsmith/permalinks and @metalsmith/sass.

Updates @metalsmith/permalinks from 2.5.1 to 3.0.0

Release notes

Sourced from @​metalsmith/permalinks's releases.

@​metalsmith/permalinks 3.0.0

Changelog

Sourced from @​metalsmith/permalinks's changelog.

v3.0.0

Commits
  • f49d926 Release 3.0.0
  • 804e1cd Updates regexparam 2.0.1 -> 3.0.0
  • 3e492ac dev: update devDependencies to latest
  • 3d7ea2e Updates README.md & types for v3.0.0
  • 053e92e Allows front-matter defined permalinks to use :placeholder patterns
  • d5d199f test: remove obsolete test
  • 552b549 BREAKING: throws an error on missing, non-optional pattern parts. See also ht...
  • 77979b5 Resolves #88, opens up permalinks usage for files with any extension.
  • 67f2432 Resolves #75, adds support for dot.notated.pattern.parts
  • a1d2a2f Updates slugify 1.6.5 -> 1.6.6
  • Additional commits viewable in compare view

Updates @metalsmith/sass from 1.8.0 to 1.8.1

Release notes

Sourced from @​metalsmith/sass's releases.

@​metalsmith/sass 1.8.1

  • Updates sass 1.69.3 -> 1.69.5 4268260
Changelog

Sourced from @​metalsmith/sass's changelog.

1.8.1

  • Updates sass 1.69.3 -> 1.69.5 4268260
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 25, 2023
@dependabot dependabot bot requested a review from a team December 25, 2023 10:23
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/metalsmith-7c1590d2b6 branch from 356733b to 9c06f09 Compare January 1, 2024 10:32
@domoscargin
Copy link
Contributor

@dependabot rebase

Bumps the metalsmith group with 2 updates: [@metalsmith/permalinks](https://github.com/metalsmith/permalinks) and [@metalsmith/sass](https://github.com/metalsmith/sass).


Updates `@metalsmith/permalinks` from 2.5.1 to 3.0.0
- [Release notes](https://github.com/metalsmith/permalinks/releases)
- [Changelog](https://github.com/metalsmith/permalinks/blob/main/CHANGELOG.md)
- [Commits](metalsmith/permalinks@v2.5.1...v3.0.0)

Updates `@metalsmith/sass` from 1.8.0 to 1.8.1
- [Release notes](https://github.com/metalsmith/sass/releases)
- [Changelog](https://github.com/metalsmith/sass/blob/main/CHANGELOG.md)
- [Commits](metalsmith/sass@1.8.0...1.8.1)

---
updated-dependencies:
- dependency-name: "@metalsmith/permalinks"
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: metalsmith
- dependency-name: "@metalsmith/sass"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: metalsmith
...

Signed-off-by: dependabot[bot] <support@github.com>
The ternary expression was flipping between two identical options
All files can now have permalinks so we must filter on `*/index.html`
Allow relative assets to be resolved via the current page rather than assuming `/` is the base
Relative URLs are no longer resolved by `@metalsmith/permalinks` but we can use canonical URLs instead
Nested paths are currently flattened due to a bug that removes slashes
@colinrotherham colinrotherham self-assigned this Jan 8, 2024
Copy link

netlify bot commented Jan 8, 2024

You can preview this change here:

Name Link
🔨 Latest commit f153e48
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/659bc777c9b1ff0008e5b184
😎 Deploy Preview https://deploy-preview-3393--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinrotherham
Copy link
Contributor

colinrotherham commented Jan 8, 2024

@domoscargin I've fixed the breaking changes but added f153e48 to work around this issue:

It's a temporary change which we can remove once fixed

Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We'll keep an eye out for the bump that fixes that bug.

@colinrotherham colinrotherham merged commit f9414bf into main Jan 8, 2024
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/metalsmith-7c1590d2b6 branch January 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants