Update marked in metalsmith build #2333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6e174b to
646027d
Compare
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
c2a4a51 to
64a71f8
Compare
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
5156ad3 to
c603040
Compare
65a29d2 to
ef33d5c
Compare
dcf2adf to
48ea004
Compare
Also stop file hashing so we don't have hashing diffs each time. Also prevent email mangling for the same reason. This allows comparisons between any future deploy builds and the current build. It must be removed before merging!
Patch change with no major issues. Of note is that this does NOT affect our build - `jstransformer-marked` 1.0.3 is using `marked` ^0.3.9 internally.
With pedantic rules, lists must have a preceding empty line. This rule is relaxed in Github Flavoured Markdown, but even if we switch to that, it'd be good to be as broadly compliant as possible.
Github Flavoured markdown supports naked links, but pedantic rules don't. So we wrap them with angle brackets. This allows for broader compliance, so we could choose to stick with this even if we changed to GFM.
The calm before the storm... We use `metalsmith-in-place` to compile our markdown and nunjucks. That in turn has a dependency on `jstransformer`, which then requires peerDependencies of the relevant packages - in this case, `jstransformer-marked` and `jstransformer-nunjucks`. So despite us having `marked` 4.0.18 as a dependency, we're at the whim of `jstransformer-marked`'s dependency tree when it comes to processing our files with `metalsmith-in-place`. v1.0.3 of `jstransformer-marked` uses `marked` ^0.3.9 (0.3.19 in our package-lock). v1.2.0 uses `marked` 4.0.18. Surely this won't be an issue... (spoiler: it will).
Take Nunjucks to 3.2.3 and drops support for Node < 8 This at least doesn't appear to affect any file processing.
501fd1a to
9e9fb5b
Compare
9e9fb5b to
ba537ab
Compare
We remove `pedantic`, since `marked` defaults to `gfm` being true.
c1c440c to
ddd1664
Compare
ddd1664 to
53bb3d5
Compare
53bb3d5 to
56c39b3
Compare
|
@domoscargin if you had trouble with
|
|
Hey @webketje, thanks for reaching out - it's not an issue with either package, thankfully - our markdown/nunjucks is just quirky because we've been using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When we merged #2276, we realised we had generated several formatting issues across the site, so we reverted that change.
We use
metalsmith-in-placeto compile our markdown and nunjucks. That in turn has a dependency onjstransformer, which then requires peerDependencies of the relevant packages - in this case,jstransformer-markedandjstransformer-nunjucks.So despite us having a fairly up to date
markedas a dependency, we're at the whim ofjstransformer-marked's dependency tree when it comes to processing our files withmetalsmith-in-place.Luckily,
jstransformer-markedhas been updated to usemarked4+. So a simple bump, right?Wrong, dear reader. Follow along commit-by-commit for the whole sorry affair.