-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary card #2251
Summary card #2251
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
Removing the guidance around ‘header-less’ summary cards definitely makes this easier to understand. Possibly just need to review what examples we give for when to use a summary card. Can’t be exhaustive, of course, but should we provide a few examples? Rather than ‘applications’, I’ve suggested:
But I’m sure there are others we could add. |
I've made a commit with guidance edits to:
Please do comment on anything that doesn't make sense — usually I'd use suggestions to do this but GitHub wouldn't let me touch any lines outside of the PR.
So I've got this down as "a set of people or professional qualifications" to match the examples we've currently got on the page, mainly to keep it simple and avoid bringing up new questions. Do we think this gives enough context for the "Use summary cards when you need to show" bullet point? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the revised description of what a summary list is, just one comment on the recommendation on when to use a summary card.
- actions that will apply to all the items in a list | ||
|
||
Summary cards are often used in case working systems, to help users quickly view information about a set of things and apply actions to them. | ||
|
||
However, summary cards may not always be appropriate for public-facing services as users might not easily understand the information the summary card is meant to show. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this line (‘However…’), seems pretty vague. I’m not sure the distinction is a public-facing service versus a case working system but more to do with the overall amount and/or complexity of the information being gathered.
Might this guidance be better suited to suggest that summary cards may not be appropriate for simple transactional services for which there is a single journey, or something along those lines? Or maybe this second line isn’t needed at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, summary cards may not always be appropriate for public-facing services as users might not easily understand the information the summary card is meant to show. |
Thanks Paul, good to hear this edit's on the right track!
I'd say let's remove the 'however' sentence — was trying to write something to discourage overuse, but does look like it'll quite work here.
I've committed a new draft of the guidance. Summary of changes:
Also with @davidc-gds**
|
b478f3f
to
57752b4
Compare
6e94132
to
fecd394
Compare
fecd394
to
2624c17
Compare
2624c17
to
91eb497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💳
Summary card is a variant of summary list contributed by @paulrobertlloyd. It's been approved by the working group and is ready for a final review. As well as adding new guidance and examples to the summary list page, it includes some new guidance on the 'check answers' pattern.
See Frontend code at alphagov/govuk-frontend#2931
See more discussion at alphagov/govuk-design-system-backlog#210