-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidance for pagination component #1972
Conversation
Hi @timpaul, all. I've made some comments and suggested some edits and to the guidance. Hope I've committed them properly into this branch — thanks! |
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as outdated.
This comment was marked as outdated.
I like where this is heading, but I found the distinction between the 3 different top-level headings hard to understand, with "set of pages" and "sequence of pages" initially sounding like the same thing to me? I wonder if we could simplify to just 2 different headings describing the 2 ways of using the component, one for "content pages" (needs a better description) which would use just previous/next, and one for "results pages" (previous/next plus numbered links and optional results line)? I can't think of a reasonable use-case for numbered links with content-y type pages? Any thoughts @timpaul? |
@timpaul in the Nunjuck examples the keys are all quoted, whereas elsewhere in the design system they're not. For example:
should be this:
|
60dcb5c
to
0394555
Compare
7cad55a
to
6ac133f
Compare
619e556
to
6489b24
Compare
Putting this on blocked for now, whilst we make final refinements to the component. |
7854807
to
f19b5d3
Compare
This guidance content should be ready to release now, just needs GitHub approvals. |
cf57f0a
to
ed4aa86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one comment
ed4aa86
to
d69d65f
Compare
Iterate content and add headings for examples Fix typo for heading level Fix headings Add guidance for pagination component Iterate content and add headings for examples Fix typo for heading level Fix headings Apply suggestions from tech writer review Co-authored-by: EoinShaughnessy <72507742+EoinShaughnessy@users.noreply.github.com> Update pagination guidance Updated guidance to: - cover issues raised by working group - clarify use case for different types of pagination - and when to use 'continue' button and back link instead Minor edits for dashes and contractions Tweaking paragraph breaks Remove section about saying "page" in labels By default, "Previous" and "next" do not include "page" so this section is no longer needed
d69d65f
to
ce9f50a
Compare
Rebased to remove pre-release from package.json and to tidy up the commit messages. |
Refine guidance for pagination component, based on design decisions and previous working group review.
Content improvements are mainly to:
Preview of page, with examples:
https://add-pagination--govuk-design-system-preview.netlify.app/components/pagination/
Other links:
Epic: Publish pagination contribution govuk-design-system#1985
Design and code is in this PR: Add pagination component #2610