Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading text info to Panel guidance #1906

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

EoinShaughnessy
Copy link
Contributor

Fixes #1901.

This PR adds content about heading text to our Panel guidance.

We're adding this info to help users keep their heading text punchy. If they use long words, it could result in the text 'wrapping' to avoid overflowing its container.

@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ You can preview this change here:

🔨 Explore the source changes: 368a17c

🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/6151f39a72bdd600079265fd

😎 Browse the preview: https://deploy-preview-1906--govuk-design-system-preview.netlify.app

@EoinShaughnessy
Copy link
Contributor Author

@calvin-lau-sig7 Can I get a review? :)

Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EoinShaughnessy
Copy link
Contributor Author

I'll merge this PR once the release notes pass 2i and we're ready to release 3.14.0.

@EoinShaughnessy EoinShaughnessy merged commit f905a05 into main Oct 4, 2021
@EoinShaughnessy EoinShaughnessy deleted the update-panel branch October 4, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add guidance about keeping panel heading brief
2 participants