-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential accessibility issue with the tab component #2719
Comments
Hi @Ciandelle, have you tried using the arrow keys to navigate between tabs? It'll either be just the left and right arrow keys by themselves, or the arrow keys paired with holding down 'alt' on Windows or 'option' on Mac. The tabs component is built as an 'ARIA widget', and ARIA widgets follow the general rule that:
This is to make it possible for people navigating via keyboard to tab past a widget they don't want to interact with, without getting lost in the widget's options. |
Ohh @Ciandelle sorry, is this the bug we got through our support email? I think it was specifically that they couldn't use tab and arrow keys to properly navigate a table inside a tab component. My bad, that is something we'll need to investigate. |
@davidc-gds Hey, yes it was, would be be helpful for me to put the full details from Zendesk in this issue so that it makes a bit more sense? |
I tested this with NVDA on Chrome, and didn't find any issues with our implementations. Here's the example frame I tested: https://design-system.service.gov.uk/components/tabs/default/index.html Test resultsHere's the full NVDA testing results in a spreadsheet.
For our implementation on the GOV.UK Design System, everything appeared to behave as expected in NVDA. Technical test detailsAssistive technology: NVDA Version 2022.4 (latest) |
Is this potentially the same as alphagov/govuk-frontend#860? Unless I'm missing something, I disagree with the conclusion that the content is inaccessible – though we could be doing better here. |
@Ciandelle it looks like this is now closed. Should we perhaps reply back to the original email we received, with the results of the tests I quickly ran? |
@davidc-gds Owen went back to the user already :) we can provide them with this if they come back to us again |
Description of the issue
unable to tab-focus and use arrow keys to navigate the data held inside the tab, and as such for a screen reader, this content is inaccessible.
Environment (where applicable)
Using NVDA screen reader and using Chrome to browse.
Next steps
We are aware of this as a potential issue and are planning to look into it further
The text was updated successfully, but these errors were encountered: