-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new and existing link modifiers in Design System #1603
Comments
Showing my working out... Figuring out what the use case is for each of these and how / where to document it:
|
What
In alphagov/govuk-frontend#2183 we're going to be introducing new classes for links:
govuk-link--inverse
for white links to use on dark backgroundsgovuk-link--no-underline
for links without underlinesThese should be documented on the links section of the typography page in the Design System so that users know how and when to use them.
There are also a couple of existing undocumented link styles which we should consider documenting:
govuk-link--muted
for grey links (which are rarely used – we could also consider deprecating this class and its mixin)govuk-link--text-colour
for black (text coloured) links – more often the mixin is used for navigational links, like back link, breadcrumb, and the links in the footer.Finally, there are the
govuk-link-style-error
andgovuk-link-style-success
mixins for error (red) and success (green) link styles, which have no corresponding modifier class. We should consider whether these modifiers should exist, and if so add them to GOV.UK Frontend and document them.Why
With the new link styles and hover states being introduced in #2183, there's a little extra complexity that needs to be considered when users roll their own link modifiers.
These modifiers cover a couple of common cases where users would currently need to implement their own link modifiers. Document them so they know they exist and can use them.
Who needs to know about this
Chris, Ollie, Calvin
Done when
The text was updated successfully, but these errors were encountered: