-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion HTML version doesn't state that IDs need to be unique #1073
Labels
Comments
NickColley
added
Priority: low
documentation
User requests new documentation or improvements to existing documentation
and removed
awaiting triage
Needs triaging by team
labels
Oct 30, 2019
Discussed with team in triage. We've not seen the wider issue come up with users so we'll keep an eye on it. We're going to document the requirement in the guidance. For context, here is the original discussion about putting the onus on the team implementing this to make the IDs unique across the domain and only documenting this in the options table. |
This would be solved by #1085 |
Open
patrickpatrickpatrick
moved this from Backlog 🏃🏼♀️
to In progress 📝
in GOV.UK Design System cycle board
May 9, 2024
patrickpatrickpatrick
added a commit
that referenced
this issue
May 9, 2024
The extra documentation for the 'id' attribute that was present in the Nunjucks options table for the accordion has been added to the 'How It Works Section'. This is because if a user is just using the HTML of the accordion component, then they might not encounter the additional documentation provided for the 'id' attribute. This addresses issue #1073.
patrickpatrickpatrick
moved this from In progress 📝
to Needs review 🔍
in GOV.UK Design System cycle board
May 9, 2024
patrickpatrickpatrick
added a commit
that referenced
this issue
May 14, 2024
The extra documentation for the 'id' attribute that was present in the Nunjucks options table for the accordion has been added to the 'How It Works Section'. This is because if a user is just using the HTML of the accordion component, then they might not encounter the additional documentation provided for the 'id' attribute. This addresses issue #1073.
patrickpatrickpatrick
added a commit
that referenced
this issue
May 14, 2024
The extra documentation for the 'id' attribute that was present in the Nunjucks options table for the accordion has been added to the 'How It Works Section'. This is because if a user is just using the HTML of the accordion component, then they might not encounter the additional documentation provided for the 'id' attribute. This addresses issue #1073.
patrickpatrickpatrick
added a commit
that referenced
this issue
May 15, 2024
The extra documentation for the 'id' attribute that was present in the Nunjucks options table for the accordion has been added to the 'How It Works Section'. This is because if a user is just using the HTML of the accordion component, then they might not encounter the additional documentation provided for the 'id' attribute. This addresses issue #1073.
patrickpatrickpatrick
moved this from Needs review 🔍
to Done 🏁
in GOV.UK Design System cycle board
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Nunjucks options table for the accordion states this for IDs:
However if you look at the HTML version this is not stated.
A user ran into an issue where they didn't know the IDs for accordions needed to be unique. I'm raising this retrospectively from the support logs and don't know if they were using the HTML version or macro but the issue could have been the lack of HTML docs.
Wider issue
There might be wider issues around how how we represent the ways of customising the component markup for HTML users as they aren't as clearly signposted as the Nunjucks ones
The text was updated successfully, but these errors were encountered: