Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused view styles #2744

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Remove unused view styles #2744

merged 2 commits into from
Apr 19, 2023

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Apr 18, 2023 •
edited
Loading

What

https://trello.com/c/fc41oyEK/1923-enable-individual-loading-of-stylesheets-in-government-frontend

Remove unused page view style sheets as a pre-requisite to implementing the AssetHelper to load component and view style sheets only required on the page being viewed.

Why

So there will be less document types to be reviewed and updated when implementing the helper.

Visual changes

None

Anything else

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 18, 2023 09:33 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from f9525e8 to 79a5ef5 Compare April 18, 2023 09:46
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 18, 2023 09:46 Inactive
@jon-kirwan jon-kirwan requested a review from MartinJJones April 18, 2023 09:48
@jon-kirwan jon-kirwan marked this pull request as ready for review April 18, 2023 09:48
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from 79a5ef5 to 24ddfe8 Compare April 18, 2023 09:51
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 18, 2023 09:51 Inactive
MartinJJones
MartinJJones approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, the changes look good to me 👍

@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from b10bf82 to eb4c15a Compare April 18, 2023 14:18
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 18, 2023 14:20 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from eb4c15a to 6ce1250 Compare April 18, 2023 17:18
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 18, 2023 17:18 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from 6ce1250 to bdffb55 Compare April 19, 2023 08:24
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 08:25 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 08:31 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 08:48 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 08:59 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from ab1abed to ec22517 Compare April 19, 2023 09:20
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 09:20 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from ec22517 to 8374133 Compare April 19, 2023 09:26
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 09:26 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from 8374133 to eaa187e Compare April 19, 2023 10:00
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 10:00 Inactive
@MartinJJones MartinJJones self-requested a review April 19, 2023 12:55
MartinJJones
MartinJJones approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good to me, can get so much done using the utility classes 👍

@jon-kirwan jon-kirwan force-pushed the remove-unused-page-views branch from eaa187e to 47ed9b5 Compare April 19, 2023 13:03
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2744 April 19, 2023 13:04 Inactive
@jon-kirwan jon-kirwan merged commit 53f8d26 into main Apr 19, 2023
@jon-kirwan jon-kirwan deleted the remove-unused-page-views branch April 19, 2023 13:10
@jon-kirwan jon-kirwan changed the title Remove unused page views Remove unused view styles Apr 19, 2023
@jon-kirwan jon-kirwan mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinJJones MartinJJones MartinJJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jon-kirwan @MartinJJones @govuk-ci