Remove rems in favour of pixels #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were never really benifiting from using rems as we never changed our base font-size. Using rems was causing issues with firefox due to the way it has implemented minimum font size. In firefox the minimum font-size ensures no element can have a font-size lower than the specified size. This was causing the html element to have a font-size bigger than the 10px we were expecting. This caused some display issues for those users.
KushalP
added a commit
that referenced
this pull request
Jul 8, 2013
Remove rems in favour of pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were never really benifiting from using rems as we never changed our
base font-size.
Using rems was causing issues with firefox due to the way it has
implemented minimum font size. In firefox the minimum font-size ensures
no element can have a font-size lower than the specified size. This was
causing the html element to have a font-size bigger than the 10px we
were expecting. This caused some display issues for those users.