This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Update macro paths to newest GOV.UK frontend #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to run this prototype now it doesn’t work, because the version of GOV.UK Frontend that you get if running ```shell npm install govuk-frontend@^3.0.0 ``` introduces a breaking change[1] that came with version 3.0.0 of GOV.UK Frontend. This repo was using a pre-release version of 3.0.0 in order to get the new focus styles. However when it was updated to 3.0.0 stable it wasn’t also updated[2] to respect the folder structure changes that came with 3.0.0. This commit updates the paths to the macros to point to the right place. 1. alphagov/govuk-frontend#1458 2. alphagov@22d7f9c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to run this prototype now it doesn’t work, because the version of GOV.UK Frontend that you get if running
introduces a breaking change1 that came with version 3.0.0 of GOV.UK Frontend.
This repo was using a pre-release version of 3.0.0 in order to get the new focus styles. However when it was updated to 3.0.0 stable it wasn’t also updated2 to respect the folder structure changes that came with 3.0.0.
This pull request updates the paths to point to the right place.