Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure AssetHelper to load individual stylesheets #1508

Merged

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Mar 15, 2023

What

https://trello.com/c/ws6n64fm/1870-enable-individual-loading-of-stylesheets-in-email-alert-frontend

Changes to load component and view style sheets only required on the page being viewed. For example, CSS for "radio" only loads on the following pages:

Why

This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.

See RFC #149 for more details.

Review URL(s)

Visual changes

None

Anything else

@jon-kirwan jon-kirwan changed the title Configure asset helper to load individual stylesheets Configure AssetHelper to load individual stylesheets Mar 15, 2023
@jon-kirwan jon-kirwan force-pushed the configure-asset-helper-to-load-individual-stylesheets branch 2 times, most recently from 8899965 to 7766e7b Compare March 16, 2023 10:37
@jon-kirwan jon-kirwan requested review from KludgeKML and maxgds March 20, 2023 09:48
@jon-kirwan jon-kirwan requested a review from MartinJJones March 20, 2023 09:49
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@jon-kirwan jon-kirwan force-pushed the configure-asset-helper-to-load-individual-stylesheets branch from 7766e7b to ce4d3ba Compare March 20, 2023 09:56
Not used since AssetHelper is configured to load individual stylesheets
@jon-kirwan jon-kirwan force-pushed the configure-asset-helper-to-load-individual-stylesheets branch from ce4d3ba to 959c81f Compare March 21, 2023 09:57
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this all looks okay to me!

@jon-kirwan jon-kirwan merged commit 0d0cd99 into main Mar 21, 2023
@jon-kirwan jon-kirwan deleted the configure-asset-helper-to-load-individual-stylesheets branch March 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants