Configure AssetHelper to load individual stylesheets #1508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://trello.com/c/ws6n64fm/1870-enable-individual-loading-of-stylesheets-in-email-alert-frontend
Changes to load component and view style sheets only required on the page being viewed. For example, CSS for "radio" only loads on the following pages:
Why
This reduces the amount of CSS required for each page and increases the ability of a browser to cache the stylesheets - this should mean a faster load time for both first time and repeat visitors.
See RFC #149 for more details.
Review URL(s)
Visual changes
None
Anything else
application.scss
from the manifest and current layout since it no longer imports any partials and compiles to an empty style sheet. I think this is a good approach since developers can still find the expectedapplication.scss
file and read the comment as to why it's empty / not loaded.