Update calls to textarea with the id option #3295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba79dfb to
2d96b57
Compare
- test is failing even though similar tests for images and attachments are passing - checking live and integration it isn't possible to add a contact as an error appears in the modal when trying to do so. Have been advised to disable the test and ignore this problem as it may be part of a wider issue
AshGDS
reviewed
Jan 22, 2025
| @@ -8,7 +8,7 @@ | |||
| and_i_select_a_contact_from_the_autcomplete | |||
| then_i_see_the_contact_preview | |||
| when_i_click_insert_contact | |||
| then_i_see_the_snippet_is_inserted | |||
| # then_i_see_the_snippet_is_inserted | |||
There was a problem hiding this comment.
You missed the slack thread - this seems to be a known problem and this was one suggested solution. I also learned that this is a deprecated repo, so yeah, think I might close it.
|
Actually, this is a deprecated repo - I'd suggest closing the PR as we don't need to upgrade anything here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update all uses of the textarea component to change the
idoption totextarea_id.Tests in this PR are likely to fail until the changes to the textarea component are included in this PR with a new gem release.
Why
Changes in alphagov/govuk_publishing_components#4574 mean that this option needs to be updated.
Visual changes
Shouldn't be any.
Trello card: https://trello.com/c/GQ1p2oSC/438-not-doing-add-component-wrapper-helper-to-form-textarea-component