-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump brakeman from 6.2.2 to 7.0.0 #1583
Conversation
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 6.2.2 to 7.0.0. - [Release notes](https://github.com/presidentbeef/brakeman/releases) - [Changelog](https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md) - [Commits](presidentbeef/brakeman@v6.2.2...v7.0.0) --- updated-dependencies: - dependency-name: brakeman dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. |
The
I've written a Trello card to investigate. |
Turns out an exit code of 3 is normal, as brakeman returns a non-zero exit code if a warning is detected during the scan. The check passed and subsequent steps on the CI process also passed. I can see the warning was correctly uploaded to GitHub as a code scanning alert: https://github.com/alphagov/asset-manager/security/code-scanning/6. This therefore seems safe to merge. |
Brakeman returns a non-zero status code when there are warnings found or errors during the scan. In 9fc187b, we allowed the GitHub Action to continue on error, so that the warning/error would be uploaded to GitHub code scanning. However the non-zero status code still gets written to the GitHub Action output. This led to confusion in alphagov/asset-manager#1583 as we thought the error meant brakeman did not complete properly. Therefore updating the brakeman configuration to report a zero status code when a warning or error is found. This means we can remove the previous change, as any completed run will not return a non-zero status code. This will also stop the non-zero code causing confusion in the GitHub Actions output.
Brakeman returns a non-zero status code when there are warnings found or errors during the scan. In 9fc187b, we allowed the GitHub Action to continue on error, so that the warning/error would be uploaded to GitHub code scanning. However the non-zero status code still gets written to the GitHub Action output. This led to confusion in alphagov/asset-manager#1583 as we thought the error meant brakeman did not complete properly, when in fact it did but was only returning that code because a code scanning warning had been found. Therefore updating the brakeman configuration to report a zero status code when a warning or error is found. This means we can remove the previous change, as any completed run will not return a non-zero status code. This will also stop the non-zero code causing confusion in the GitHub Actions output.
Bumps brakeman from 6.2.2 to 7.0.0.
Release notes
Sourced from brakeman's releases.
Changelog
Sourced from brakeman's changelog.
Commits
2f2cd21
Relax Prism version for --prism too76da00a
Bump to 7.0.0b0eb1fc
Merge pull request #1904 from presidentbeef/relax_prism_version5ae38b9
Relax Prism version requirementc7018cd
Update CHANGES5f37891
Merge pull request #1902 from presidentbeef/update_deserialize_checkd834150
OutputoriginalBaseUriIds
for SARIF report (#1890)ee9de40
Use Prism parser by default (#1897)f891743
Always warn about deserializing with Marshalb299ca0
Merge pull request #1899 from presidentbeef/update_eval_checkDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)