n-body improvements #813
Merged
n-body improvements #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it simple to test the benchmark with a custom thread count by just setting the OMP_NUM_THREADS environment variable.
The version with compile-time bit counts is what one should use in production.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #813 +/- ##
========================================
Coverage 98.77% 98.77%
========================================
Files 75 75
Lines 7350 7350
========================================
Hits 7260 7260
Misses 90 90 |
Disable: llvm-qualified-auto,readability-qualified-auto To suppress e.g.: 'const auto title' can be declared as 'const auto *const title'
4475c84 to
58b49bd
Compare
examples/alpaka/nbody/nbody.cpp:166:80: error: reference to local variable 'mapping' declared in enclosing lambda expression
return allocViewUninitialized(mapping, llama::bloballoc::Array<mapping.blobSize(0)>{});
58b49bd to
27b5bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve and simplify the n-body examples: