Extend viewcopy benchmark and improve llama::copy #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #811 +/- ##
===========================================
- Coverage 98.78% 98.77% -0.02%
===========================================
Files 75 75
Lines 7340 7350 +10
===========================================
+ Hits 7251 7260 +9
- Misses 89 90 +1 |
adc7c83 to
c81bdf0
Compare
* Remove memcpy from benchmark result table * Test each mapping against each other * Use fmt consistently
We want to always read contigously from the AoSoA layout with the smaller lane count. SoA is an AoSoA with a very large lane count.
c81bdf0 to
aef4a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.