Heatmap improvements #704
Merged
Heatmap improvements #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bernhardmgruber
commented
Feb 13, 2023
•
- Fail loudly when Heatmap is used with a computed mapping
- Extend mapping trait test with Heatmap
- Add hasAnyComputedField trait
- Fix wrong blobSize calculation in Heatmap
- Return a span in Heatmap::blockHits
* Rename the pointer returning function to blockHitsPtr * Add a new function blockHits returning a span, when C++20 is available
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #704 +/- ##
========================================
Coverage 98.77% 98.78%
========================================
Files 74 74
Lines 7119 7157 +38
========================================
+ Hits 7032 7070 +38
Misses 87 87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.