Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply to new CRP clang-tidy checks #573

Merged
merged 1 commit into from
Sep 14, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
---
# -bugprone-forward-declaration-namespace # too many false positives in LLAMA
# -cppcoreguidelines-macro-usage # too many macros flagged, which cannot be replaced by constexpr
# -bugprone-exception-escape # bgruber is fine with exceptions escaping main we cannot add main as an exception
# -readability-misleading-indentation # many false positives because of constexpr if
# -readability-static-accessed-through-instance # flags threadIdx/blockIdx in CUDA code
# -cert-err58-cpp # errors in Catch2
# -fuchsia-statically-constructed-objects # too much noise with Catch2
# -bugprone-easily-swappable-parameters # too noisy
# bugprone-forward-declaration-namespace # too many false positives in LLAMA
# cppcoreguidelines-macro-usage # too many macros flagged, which cannot be replaced by constexpr
# bugprone-exception-escape # bgruber is fine with exceptions escaping main we cannot add main as an exception
# readability-misleading-indentation # many false positives because of constexpr if
# readability-static-accessed-through-instance # flags threadIdx/blockIdx in CUDA code
# cert-err58-cpp # errors in Catch2
# fuchsia-statically-constructed-objects # too much noise with Catch2
# bugprone-easily-swappable-parameters # too noisy
# altera-struct-pack-align # too noisy, flags e.g. all traits
Checks: >
*,
-bugprone-exception-escape,
Expand Down Expand Up @@ -81,3 +82,4 @@ CheckOptions:
- { key: readability-identifier-naming.UnionCase, value: CamelCase}
- { key: readability-identifier-naming.ValueTemplateParameterCase, value: CamelCase}
- { key: readability-identifier-naming.VariableCase, value: camelBack}
- { key: performance-for-range-copy.WarnOnAllAutoCopies, value: 1}