Support proxy references in RecordRef tuple interface #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
404d112 to
1a1cf89
Compare
This uncovered missing initializations in some tests.
1a1cf89 to
5be7a05
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #572 +/- ##
===========================================
+ Coverage 98.91% 98.97% +0.06%
===========================================
Files 64 64
Lines 6068 6136 +68
===========================================
+ Hits 6002 6073 +71
+ Misses 66 63 -3 |
This should improve readability and make the return type more clearly visible.
5be7a05 to
86a2e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuple interface of
RecordRefallows to convert between aRecordRefand a user-defined struct implementing the tuple interface. This did not work though if theRecordRefused a mapping using proxy references. This PR fixes this shortcoming.On the side, the constructor of
BitPackedIntSoAhas been improved to detect uninitialized bit sizes. This uncovered some errors in the unit tests, which were fixed as well.