Enforce identifier naming #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
767886b to
c4d7ea7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #565 +/- ##
========================================
Coverage 98.82% 98.82%
========================================
Files 64 64
Lines 6036 6038 +2
========================================
+ Hits 5965 5967 +2
Misses 71 71 |
6e2e647 to
5041b77
Compare
5041b77 to
1684d32
Compare
1684d32 to
235530c
Compare
|
I will create a new PR for increasing the test coverage of the dump tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names used in LLAMA have grown too inconsistent over time. Mostly a mix of
camelBack,CamelCaseandsnake_caseis used. This PR enables several more identifier naming checks in clang-tidy and enforces them in the CI.