Extend Trace mapping and allow GPU usage #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae468c1 to
89c9f83
Compare
Codecov Report
@@ Coverage Diff @@
## develop #503 +/- ##
========================================
Coverage 99.24% 99.25%
========================================
Files 63 63
Lines 5439 5475 +36
========================================
+ Hits 5398 5434 +36
Misses 41 41 |
89c9f83 to
1504029
Compare
* Move Trace mapping field hit storage into blob. This makes the Trace mapping a computed mapping, since it needs access to the blobs. * Printing of the summary is now explicit and no longer automatic in the dtor. * Make Trace mapping separately count reads/writes * Trace mapping works on GPU now Fixes: alpaka-group#487
1504029 to
7e88d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trace mapping has been restructured to allow usage on GPUs. For this to work, the access count arrays are no longer kept inside the mapping instance but placed into an additional blob. The report now needs to be requested explicitely, instead of an implicit report upon mapping instance destruction.
The Trace mapping now has two modes: the default counts reads and writes separately, but requires proxy references to work. The simplified mode avoids proxy references but can only count the number of memory location computations.
Fixes: #487