Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add missing PreconfiguredMapping and isMapping #456

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Dec 26, 2021

Rename all meta functions PreconfiguredX, for all mappings X to BindX. Also rename the nested type alias template to fn. This makes LLAMA more coherent with other quoted meta functions.
This PR also adds missing isX detection functions for all mappings (except Trace/Heatmap) where missing.

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #456 (e4098f4) into develop (69adc29) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #456      +/-   ##
===========================================
+ Coverage    99.22%   99.23%   +0.01%     
===========================================
  Files           59       59              
  Lines         5296     5371      +75     
===========================================
+ Hits          5255     5330      +75     
  Misses          41       41              
Impacted Files Coverage Δ
include/llama/mapping/AoS.hpp 100.00% <ø> (ø)
include/llama/mapping/AoSoA.hpp 100.00% <ø> (ø)
include/llama/mapping/BitPackedFloatSoA.hpp 100.00% <ø> (ø)
include/llama/mapping/BitPackedIntSoA.hpp 100.00% <ø> (ø)
include/llama/mapping/Bytesplit.hpp 100.00% <ø> (ø)
include/llama/mapping/ChangeType.hpp 100.00% <ø> (ø)
include/llama/mapping/Null.hpp 100.00% <ø> (ø)
include/llama/mapping/One.hpp 100.00% <ø> (ø)
include/llama/mapping/SoA.hpp 100.00% <ø> (ø)
include/llama/mapping/Split.hpp 100.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69adc29...e4098f4. Read the comment docs.

@bernhardmgruber bernhardmgruber force-pushed the bin branch 2 times, most recently from 095b38e to 2b7e8ff Compare December 26, 2021 16:48
@bernhardmgruber bernhardmgruber marked this pull request as ready for review December 26, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant