Fix LLAMA_INDEPENDENT_DATA not correctly defined for clang #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang also defines __GNUC__ and LLAMA_INDEPENDENT_DATA will be defined using GCC's pragmas and not clang's.
…DENT_DATA, but not distribution The semantic of LLAMA_INDEPENDENT_DATA is to signal independent memory accesses, so we can guarantee safe parallel access. Allowing the compiler to distribute loops is not necessary and goes beyond the meaning of LLAMA_INDEPENDENT_DATA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang in addition to gcc also defines
__GNUC__and this is the first check when definingLLAMA_INDEPENDENT_DATA, so the macro will be defined using GCC's pragmas and not clang's.Furthermore,
LLAMA_INDEPENDENT_DATAwill be changed for clang to also guarantee safe parallel memory access (more guarantees then now), but not encourage loop destribution (which is not part of the semantic ofLLAMA_INDEPENDENT_DATA).