Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Vector, a 1D container #300

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Jun 10, 2021

Addresses #296.

The implementation is not complete but contains a reasonably usable subset of what std::vector offers.

For the unit tests, I started with https://github.com/MFHava/PTL/blob/master/test/vector.cpp, but the current state is far different now. @MFHava would you consider the tests/vector.cpp in this PR still derived work from your original source? If yes, I would leave the license header as is and still need to add the Boost license file somewhere.

@bernhardmgruber bernhardmgruber force-pushed the vector branch 2 times, most recently from dd1482b to 032ea28 Compare June 10, 2021 20:06
@MFHava
Copy link

MFHava commented Jun 10, 2021

@MFHava would you consider the tests/vector.cpp in this PR still derived work from your original source?

Skimming through your unit tests, I don't see anything that would necessitate that - is there even one line of code from me remaining? If there isn't, just go ahead and claim authorship...

@bernhardmgruber
Copy link
Member Author

@MFHava would you consider the tests/vector.cpp in this PR still derived work from your original source?

Skimming through your unit tests, I don't see anything that would necessitate that - is there even one line of code from me remaining? If there isn't, just go ahead and claim authorship...

There is probably no line remaining unchanged. There are things like the default ctor check:

const ptl::vector<int> v0;
REQUIRE(v0.empty());

That became:

const Vector v;
CHECK(v.empty());

So there are a few lines left which carry on the idea. But the big portion is work of my own. Reading wikipedia on derivative work, which is by no means legal advice, but maybe a good guidance, it says:

a derivative work is an expressive creation that includes major copyrightable elements of an original, previously created first work

I therefore would like to conclude that my unit tests are not derivative work since close to zero elements were taken over. @MFHava is that assessment correct in your opinion?

@bernhardmgruber bernhardmgruber marked this pull request as ready for review June 11, 2021 10:30
@MFHava
Copy link

MFHava commented Jun 11, 2021

Yeah, just go ahead...

@bernhardmgruber bernhardmgruber linked an issue Jun 11, 2021 that may be closed by this pull request
@bernhardmgruber bernhardmgruber merged commit 63508c2 into alpaka-group:develop Jun 11, 2021
@bernhardmgruber bernhardmgruber deleted the vector branch June 11, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants