Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift copy implementations into llama #289

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Lift copy implementations into llama #289

merged 1 commit into from
Jul 6, 2021

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Jun 4, 2021 •
edited
Loading

The viewcopy example prototyped several implementations for a mapping aware copy between two views. This PR lifts these into LLAMA.

  • verify they perform the same as before being lifted into LLAMA
  • add unit tests
  • add documentation

@bernhardmgruber bernhardmgruber force-pushed the viewcopy branch 5 times, most recently from 931ce77 to 73e1572 Compare July 1, 2021 14:45
@bernhardmgruber bernhardmgruber marked this pull request as ready for review July 1, 2021 15:02
j-stephan
j-stephan requested changes Jul 2, 2021
View reviewed changes
docs/pages/copying.rst Outdated Show resolved Hide resolved
docs/pages/copying.rst Outdated Show resolved Hide resolved
examples/viewcopy/viewcopy.cpp Show resolved Hide resolved
include/llama/mapping/AoS.hpp Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
@bernhardmgruber bernhardmgruber force-pushed the viewcopy branch 4 times, most recently from 05289e7 to a109c05 Compare July 5, 2021 08:38
@bernhardmgruber bernhardmgruber requested a review from j-stephan July 5, 2021 09:07
@bernhardmgruber bernhardmgruber linked an issue Jul 5, 2021 that may be closed by this pull request
Move view copy into LLAMA #272
Closed
j-stephan
j-stephan requested changes Jul 5, 2021
View reviewed changes
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Outdated Show resolved Hide resolved
include/llama/Copy.hpp Show resolved Hide resolved
@bernhardmgruber bernhardmgruber force-pushed the viewcopy branch 2 times, most recently from 14a2ab4 to 62472f8 Compare July 6, 2021 15:17
@bernhardmgruber
lift copy implementations from example into llama
8b496f4 
Move the copy strategies from the viewcopy example into llama.
Add a new blobMemcpy strategy.
Add documentation.
Add unit tests.
Fix always defaulting to std::memcpy for parallel memcpy.
@bernhardmgruber bernhardmgruber merged commit 8e938f4 into alpaka-group:develop Jul 6, 2021
@bernhardmgruber bernhardmgruber deleted the viewcopy branch July 6, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-stephan j-stephan j-stephan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move view copy into LLAMA
2 participants
@bernhardmgruber @j-stephan