Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename domains to record dimension and array dimensions #194

Merged
merged 7 commits into from
Apr 20, 2021

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Mar 30, 2021

After several internal discussions, we think renaming the datum domain into record dimension and array domain into array dimensions would increase clarity a lot. See also: #176

  • Rename ArrayDomain into Array dimensions.
  • Rename DatumDomain into Record dimension.
  • Extend concept graphic with access pattern, target hardware info, exchangeable mapping and layout changing copies.
  • Rename VirtualDatum to VirtualRecord
  • Rename DatumCoord to RecordCoord
  • Rename DatumStruct to Record
  • Rename DatumElement to Field
  • Rename lots of helper functions
  • Rename variables containing datum
  • Rename literal operator _DC into _RC
  • Rename ArrayDomainRange to ArrayDimsIndexRange
  • Replace term domain by dimensions where appropriate
  • Update images

@bernhardmgruber bernhardmgruber changed the title Rename domains in to record dimension and array dimensions Rename domains to record dimension and array dimensions Mar 30, 2021
@bernhardmgruber bernhardmgruber force-pushed the domain_rename branch 2 times, most recently from 3d4d1f3 to 9f217c6 Compare March 30, 2021 11:01
@bernhardmgruber bernhardmgruber force-pushed the domain_rename branch 3 times, most recently from cb79147 to 87f72a7 Compare April 19, 2021 09:28
@bernhardmgruber bernhardmgruber marked this pull request as ready for review April 19, 2021 15:19
@bernhardmgruber bernhardmgruber force-pushed the domain_rename branch 3 times, most recently from b4e635b to 1d7e796 Compare April 19, 2021 17:56
Rename ArrayDomain into Array dimensions.
Rename DatumDomain into Record dimension.
Add access pattern, target hardware info, exchangeable mapping and layout changing copies.
* rename corresponding files
* rename VirtualDatum to VirtualRecord
* rename DatumCoord to RecordCoord
* rename DatumStruct to Record
* rename DatumElement to Field
* rename lots of helper functions
* rename variables containing datum
* rename literal operator _DC into _RC
* update images
*
* Rename ArrayDomainRange to ArrayDimsIndexRange
* Replace term domain by dimensions where appropriate
* Update images
@bernhardmgruber bernhardmgruber merged commit 76b5385 into alpaka-group:develop Apr 20, 2021
@bernhardmgruber bernhardmgruber deleted the domain_rename branch April 20, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant