Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amalgamated header depends on fmt #251

Closed
bernhardmgruber opened this issue May 19, 2021 · 0 comments · Fixed by #422
Closed

Amalgamated header depends on fmt #251

bernhardmgruber opened this issue May 19, 2021 · 0 comments · Fixed by #422
Labels
bug Something isn't working

Comments

@bernhardmgruber
Copy link
Member

The fmt library is used in LLAMA's DumpMapping.h for string formatting. This header is not include by default to allow users to use LLAMA even without installing fmt. However, the amalgamated header includes DumpMapping.h, so it is only usable when fmt is installed.
@bernhardmgruber bernhardmgruber added the bug Something isn't working label Jul 9, 2021
bernhardmgruber added a commit to bernhardmgruber/llama that referenced this issue Dec 2, 2021
@bernhardmgruber
include DumpMapping.hpp with llama.hpp
5cf2c37 
Disable DumpMapping.hpp content when libfmt is not available.
Fixes amalgamated header depending on libfmt: alpaka-group#251
@bernhardmgruber bernhardmgruber mentioned this issue Dec 2, 2021
Merged
bernhardmgruber added a commit that referenced this issue Dec 3, 2021
@bernhardmgruber
include DumpMapping.hpp with llama.hpp
4381104 
Disable DumpMapping.hpp content when libfmt is not available.
Fixes amalgamated header depending on libfmt: #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include DumpMapping.hpp with llama.hpp bernhardmgruber/llama
1 participant
@bernhardmgruber