Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYCL FPGA support to the job generator #2474

Merged

Conversation

SimeonEhrig
Copy link
Member

No description provided.

@SimeonEhrig SimeonEhrig force-pushed the jobGeneratorAddSyclFpgaSupport branch 2 times, most recently from 75db4eb to 95baa01 Compare February 4, 2025 14:21
@psychocoderHPC
Copy link
Member

@SimeonEhrig I saw in the failing CI jobs

The following tests FAILED:
	 12 - parallelLoopPatterns (Timeout)

I merged today #2456 maybe it is required to rebase against the fix

@SimeonEhrig
Copy link
Member Author

@fwyzard Does PR #2456 fix the broken test? If yes, can you please rebase PR #2471 that I can rebase this PR.

@SimeonEhrig SimeonEhrig force-pushed the jobGeneratorAddSyclFpgaSupport branch from 95baa01 to fb4e5a9 Compare February 6, 2025 08:36
@fwyzard fwyzard changed the title Job generator add sycl fpga support Add SYCL FPGA support to the job generator Feb 13, 2025
@fwyzard fwyzard force-pushed the jobGeneratorAddSyclFpgaSupport branch from fb4e5a9 to 2ab700a Compare February 13, 2025 21:35
@fwyzard
Copy link
Contributor

fwyzard commented Feb 13, 2025

I've done all the rebasing, let's see how the tests go.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 13, 2025

Looks like the blockSharedSharingTest test fails with the FPGA backend in debug mode.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 18, 2025

...we were just in time for intel/llvm#16929 :-/

@SimeonEhrig
Copy link
Member Author

...we were just in time for intel/llvm#16929 :-/

How do we continue? I think it makes no sense anymore to merge the PR, except you still want to do FPGA develop and maybe is it in another way later.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 18, 2025

I would prefer to merge it and continue the work!
This summer we have a student sponsored by Intel (or Altera) to work on FPGAs.

@SimeonEhrig
Copy link
Member Author

I would prefer to merge it and continue the work!
This summer we have a student sponsored by Intel (or Altera) to work on FPGAs.

Okay. The PR is ready to be reviewed and merged. Your PR should be automatically merged too.

@fwyzard fwyzard merged commit 1793a07 into alpaka-group:develop Feb 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants