Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript for React components #366

Merged
merged 26 commits into from
Feb 14, 2024
Merged

Add Typescript for React components #366

merged 26 commits into from
Feb 14, 2024

Conversation

alookatommorow
Copy link
Owner

@alookatommorow alookatommorow commented Feb 13, 2024

Add Typescript

Configure shakapacker to use TS and begin conversion of React components to TS

  • add necessary devdependencies
  • add tsconfig
  • configure prettier and eslint
  • configure webpack
  • convert Review, Modal, Search, and more components to TS
  • use protect_from_forgery with: :null_session in application_controller to allow requests from react components
  • move favorite/visit routes into api controller namespace
  • add ApiErrorHandler for graceful error handling in api controller namespace
  • remove obsolete ReviewsController
  • silence administrate deprecation warning by removing class_name option when declaring dashboards option since it is now inferred (see Automatic associations thoughtbot/administrate#1633)
  • add skatepark_images to seeds
  • remove redirect added in add redirect #307

Note: Heroku builds automatically prune devDependencies which are now required for TS in asset precompilation, so adding Heroku configuration to environments was required to fix the build
heroku config:set YARN_PRODUCTION=false -a <app-name>

Screenshot 2024-02-21 at 12 57 51 PM

@alookatommorow alookatommorow merged commit 4ed15b9 into main Feb 14, 2024
1 check passed
@alookatommorow alookatommorow deleted the feat/ts branch February 14, 2024 05:05
@alookatommorow alookatommorow changed the title Feat/ts Add Typescript for React components Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant