-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typescript for React components #366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8350aa4
to
bca7b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Typescript
Configure shakapacker to use TS and begin conversion of React components to TS
Review
,Modal
,Search
, and more components to TSprotect_from_forgery with: :null_session
inapplication_controller
to allow requests from react componentsApiErrorHandler
for graceful error handling in api controller namespaceReviewsController
class_name
option when declaring dashboards option since it is now inferred (see Automatic associations thoughtbot/administrate#1633)skatepark_images
to seedsNote: Heroku builds automatically prune
devDependencies
which are now required for TS in asset precompilation, so adding Heroku configuration to environments was required to fix the buildheroku config:set YARN_PRODUCTION=false -a <app-name>