Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Add icon option to ShapeBase #3756

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Add icon option to ShapeBase #3756

merged 3 commits into from
Jan 5, 2018

Conversation

pdugas
Copy link

@pdugas pdugas commented Jan 3, 2018

Per #3743, adds support for the icon option for nodes based on ShapeBase. Centers a font-icon glyph in the center of the node shape. Allows the shape and color to denote node type and state leaving the optional label for identification.

Copy link
Contributor

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@yotamberk yotamberk merged commit a42368c into almende:develop Jan 5, 2018
@isanchen
Copy link

isanchen commented Jan 10, 2019

Hi gents, thanks for the great work to bring in this capability, exactly what we wanted (and so did many others I am sure)!

Just curious about the status of the develop branch, is there an ETA when this can be released? And/or if there is anything the community can help remove any blockers?

isanchen pushed a commit to isanchen/vis that referenced this pull request Jan 10, 2019
* Add support for `icon` option to ShapeBase

* Add test/example for new ShapeBase `icon` option

* Update docs for new `icon` ShapeBase option
@jafri
Copy link

jafri commented Mar 18, 2019

Will this be merged to master?

mojoaxel pushed a commit to visjs/vis_original that referenced this pull request Jun 9, 2019
* Add support for `icon` option to ShapeBase

* Add test/example for new ShapeBase `icon` option

* Update docs for new `icon` ShapeBase option
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants