This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Adds code coverage report the output of npm test and adds detailed …
#3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 14, 2017 20:03
…html code coverage report using the command `npm run-script test-cov`
…e coverage stats are complete.
yotamberk
approved these changes
Oct 20, 2017
|
@macleodbroad-wf 😂 Working, awesome! Perhaps a bit too much output for the unit tests?
|
mojoaxel
pushed a commit
to visjs/vis_original
that referenced
this pull request
Jun 9, 2019
almende#3575) * Adds code coverage report the output of `npm test` and adds detailed html code coverage report using the command `npm run-script test-cov` * Switch over to using functions in lib/ rather than dist/, so that code coverage stats are complete. * Import vis at the top level to keep ItemSet passing * Remove requirement for dist/vis in TimelineItemSet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…html code coverage report using the command
npm run-script test-covAdded to test output is a table showing test coverage output:
And the html code coverage is a much more detailed:
Index:
Individual file:
My hope is that after this merges, we can look at adding something to the build process, to show code coverage report diffs for each incoming PR (Using codecov.io or something similar).
I find this very useful for identifying where I should target to add more unit tests, and to verify how well we're testing things. Based on the current state of the report, I'd say we have some work to do.