Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate history id based on all test case parameters #498

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

andrcuns
Copy link
Collaborator

@andrcuns andrcuns commented Jun 6, 2023

Take in to account all test case parameters when generating history id to make sure it's unique based on parameters set for test case.

Fixes: #494


Allure report

allure-report-publisher generated test report!

rspec: ✅ test report for c3d8c712

+--------------------------------------------------------------------------+
|                            behaviors summary                             |
+---------------------+--------+--------+---------+-------+-------+--------+
|                     | passed | failed | skipped | flaky | total | result |
+---------------------+--------+--------+---------+-------+-------+--------+
| allure-cucumber     | 192    | 0      | 0       | 0     | 192   ||
| allure-rspec        | 126    | 0      | 0       | 0     | 126   ||
| allure-ruby-commons | 546    | 0      | 0       | 0     | 546   ||
+---------------------+--------+--------+---------+-------+-------+--------+
| Total               | 864    | 0      | 0       | 0     | 864   ||
+---------------------+--------+--------+---------+-------+-------+--------+

@andrcuns andrcuns added the bug Something isn't working label Jun 6, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit c3d8c71 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

Revert back to using instance_variables in jsonable

Skip parameters and history_id memoize

Add ruby and oj test parameters

Add env vars to test step
@andrcuns andrcuns force-pushed the fix-history-id-all-parameters branch from bee9d7c to c3d8c71 Compare June 6, 2023 18:45
@andrcuns andrcuns changed the title Calculate history id based on all test case parameters [BREAKING] Calculate history id based on all test case parameters Jun 6, 2023
@andrcuns andrcuns changed the title [BREAKING] Calculate history id based on all test case parameters Calculate history id based on all test case parameters Jun 6, 2023
@andrcuns andrcuns merged commit 851017d into master Jun 6, 2023
@andrcuns andrcuns deleted the fix-history-id-all-parameters branch June 6, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for influencing history id based on environment properties
1 participant