Update actions #26
Update actions #26
Conversation
WalkthroughThis update introduces three new GitHub Actions: Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (3)
Files skipped from review due to trivial changes (1)
Additional comments not posted (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
| curl -X POST "${{ env.SLACK_GITHUB_ACTIONS_WEBHOOK }}" -H "Content-Type: application/json" \ | ||
| -d "{\"blocks\":[{\"text\":{\"text\":\"*Name:* ${{ env.PROJECT }} nightly security check\\n*Type:* cron-job\\n*Text:* Security check failed\\n><$JOB_URL|View failing job>\",\"type\":\"mrkdwn\"},\"type\":\"section\"}],\"text\":\"\"}" |
There was a problem hiding this comment.
Improve readability of the curl command.
Break down the long curl command into multiple lines for better readability.
- curl -X POST "${{ env.SLACK_GITHUB_ACTIONS_WEBHOOK }}" -H "Content-Type: application/json" \
- -d "{\"blocks\":[{\"text\":{\"text\":\"*Name:* ${{ env.PROJECT }} nightly security check\\n*Type:* cron-job\\n*Text:* Security check failed\\n><$JOB_URL|View failing job>\",\"type\":\"mrkdwn\"},\"type\":\"section\"}],\"text\":\"\"}"
+ curl -X POST "${{ env.SLACK_GITHUB_ACTIONS_WEBHOOK }}" \
+ -H "Content-Type: application/json" \
+ -d '{
+ "blocks": [
+ {
+ "text": {
+ "text": "*Name:* ${{ env.PROJECT }} nightly security check\n*Type:* cron-job\n*Text:* Security check failed\n><$JOB_URL|View failing job>",
+ "type": "mrkdwn"
+ },
+ "type": "section"
+ }
+ ],
+ "text": ""
+ }'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| curl -X POST "${{ env.SLACK_GITHUB_ACTIONS_WEBHOOK }}" -H "Content-Type: application/json" \ | |
| -d "{\"blocks\":[{\"text\":{\"text\":\"*Name:* ${{ env.PROJECT }} nightly security check\\n*Type:* cron-job\\n*Text:* Security check failed\\n><$JOB_URL|View failing job>\",\"type\":\"mrkdwn\"},\"type\":\"section\"}],\"text\":\"\"}" | |
| curl -X POST "${{ env.SLACK_GITHUB_ACTIONS_WEBHOOK }}" \ | |
| -H "Content-Type: application/json" \ | |
| -d '{ | |
| "blocks": [ | |
| { | |
| "text": { | |
| "text": "*Name:* ${{ env.PROJECT }} nightly security check\n*Type:* cron-job\n*Text:* Security check failed\n><$JOB_URL|View failing job>", | |
| "type": "mrkdwn" | |
| }, | |
| "type": "section" | |
| } | |
| ], | |
| "text": "" | |
| }' |
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \ | ||
| --table-name "${{ env.TABLE_NAME }}" \ | ||
| --update-expression "SET passed = :status" \ | ||
| --expression-attribute-values '{":status":{"BOOL":false}}' \ | ||
| --key="$keyJson" |
There was a problem hiding this comment.
Improve readability of the DynamoDB update command.
Break down the long DynamoDB update command into multiple lines for better readability.
- aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \
- --table-name "${{ env.TABLE_NAME }}" \
- --update-expression "SET passed = :status" \
- --expression-attribute-values '{":status":{"BOOL":false}}' \
- --key="$keyJson"
+ aws-vault exec --backend=pass allthings-development-github-role -- \
+ aws dynamodb update-item \
+ --table-name "${{ env.TABLE_NAME }}" \
+ --update-expression "SET passed = :status" \
+ --expression-attribute-values '{":status":{"BOOL":false}}' \
+ --key="$keyJson"Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \ | |
| --table-name "${{ env.TABLE_NAME }}" \ | |
| --update-expression "SET passed = :status" \ | |
| --expression-attribute-values '{":status":{"BOOL":false}}' \ | |
| --key="$keyJson" | |
| aws-vault exec --backend=pass allthings-development-github-role -- \ | |
| aws dynamodb update-item \ | |
| --table-name "${{ env.TABLE_NAME }}" \ | |
| --update-expression "SET passed = :status" \ | |
| --expression-attribute-values '{":status":{"BOOL":false}}' \ | |
| --key="$keyJson" |
| - name: Set to in passed | ||
| env: | ||
| BRANCH_NAME: ${{ github.ref_name }} | ||
| COMMAND_ACTION: ${{ inputs.action }} | ||
| PROJECT: ${{ inputs.project }} | ||
| TABLE_NAME: allthings-github-actions-status | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ env.COMMAND_ACTION }}" != "passed" ]; then exit 0; fi | ||
|
|
||
| keyJson="{\"pk\":{\"S\":\"${{ env.PROJECT }}-${{ env.BRANCH_NAME }}\"}}" | ||
| { | ||
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \ | ||
| --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" \ | ||
| --update-expression "SET passed = :status" \ | ||
| --expression-attribute-values '{":status":{"BOOL":true}}' | ||
| } || { | ||
| exit 1 | ||
| } |
There was a problem hiding this comment.
Improve readability of the DynamoDB update command.
Break down the long DynamoDB update command into multiple lines for better readability.
- aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \
- --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" \
- --update-expression "SET passed = :status" \
- --expression-attribute-values '{":status":{"BOOL":true}}'
+ aws-vault exec --backend=pass allthings-development-github-role -- \
+ aws dynamodb update-item \
+ --table-name "${{ env.TABLE_NAME }}" \
+ --key="$keyJson" \
+ --update-expression "SET passed = :status" \
+ --expression-attribute-values '{":status":{"BOOL":true}}'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Set to in passed | |
| env: | |
| BRANCH_NAME: ${{ github.ref_name }} | |
| COMMAND_ACTION: ${{ inputs.action }} | |
| PROJECT: ${{ inputs.project }} | |
| TABLE_NAME: allthings-github-actions-status | |
| shell: bash | |
| run: | | |
| if [ "${{ env.COMMAND_ACTION }}" != "passed" ]; then exit 0; fi | |
| keyJson="{\"pk\":{\"S\":\"${{ env.PROJECT }}-${{ env.BRANCH_NAME }}\"}}" | |
| { | |
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb update-item \ | |
| --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" \ | |
| --update-expression "SET passed = :status" \ | |
| --expression-attribute-values '{":status":{"BOOL":true}}' | |
| } || { | |
| exit 1 | |
| } | |
| { | |
| aws-vault exec --backend=pass allthings-development-github-role -- \ | |
| aws dynamodb update-item \ | |
| --table-name "${{ env.TABLE_NAME }}" \ | |
| --key="$keyJson" \ | |
| --update-expression "SET passed = :status" \ | |
| --expression-attribute-values '{":status":{"BOOL":true}}' | |
| } || { | |
| exit 1 | |
| } |
| - name: Set to in passed | ||
| env: | ||
| BRANCH_NAME: ${{ github.ref_name }} | ||
| COMMAND_ACTION: ${{ inputs.action }} | ||
| PROJECT: ${{ inputs.project }} | ||
| TABLE_NAME: allthings-github-actions-status | ||
| shell: bash | ||
| run: | | ||
| if [ "${{ env.COMMAND_ACTION }}" != "status" ]; then exit 0; fi | ||
|
|
||
| keyJson="{\"pk\":{\"S\":\"${{ env.PROJECT }}-${{ env.BRANCH_NAME }}\"}}" | ||
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb get-item \ | ||
| --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" | grep "\"BOOL\": true" || exit 1 |
There was a problem hiding this comment.
Ensure error handling for the DynamoDB get-item command.
Ensure that errors are handled gracefully when the DynamoDB get-item command fails.
- aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb get-item \
- --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" | grep "\"BOOL\": true" || exit 1
+ aws-vault exec --backend=pass allthings-development-github-role -- \
+ aws dynamodb get-item \
+ --table-name "${{ env.TABLE_NAME }}" \
+ --key="$keyJson" | grep "\"BOOL\": true" || {
+ echo "Error: DynamoDB get-item command failed."
+ exit 1
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Set to in passed | |
| env: | |
| BRANCH_NAME: ${{ github.ref_name }} | |
| COMMAND_ACTION: ${{ inputs.action }} | |
| PROJECT: ${{ inputs.project }} | |
| TABLE_NAME: allthings-github-actions-status | |
| shell: bash | |
| run: | | |
| if [ "${{ env.COMMAND_ACTION }}" != "status" ]; then exit 0; fi | |
| keyJson="{\"pk\":{\"S\":\"${{ env.PROJECT }}-${{ env.BRANCH_NAME }}\"}}" | |
| aws-vault exec --backend=pass allthings-development-github-role -- aws dynamodb get-item \ | |
| --table-name "${{ env.TABLE_NAME }}" --key="$keyJson" | grep "\"BOOL\": true" || exit 1 | |
| - name: Set to in passed | |
| env: | |
| BRANCH_NAME: ${{ github.ref_name }} | |
| COMMAND_ACTION: ${{ inputs.action }} | |
| PROJECT: ${{ inputs.project }} | |
| TABLE_NAME: allthings-github-actions-status | |
| shell: bash | |
| run: | | |
| if [ "${{ env.COMMAND_ACTION }}" != "status" ]; then exit 0; fi | |
| keyJson="{\"pk\":{\"S\":\"${{ env.PROJECT }}-${{ env.BRANCH_NAME }}\"}}" | |
| aws-vault exec --backend=pass allthings-development-github-role -- \ | |
| aws dynamodb get-item \ | |
| --table-name "${{ env.TABLE_NAME }}" \ | |
| --key="$keyJson" | grep "\"BOOL\": true" || { | |
| echo "Error: DynamoDB get-item command failed." | |
| exit 1 | |
| } |
Update actions from workflow
Summary by CodeRabbit