Fix dhooks regression #2249
Merged
Fix dhooks regression #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headline
approved these changes
Jan 23, 2025
961615e to
77e016f
Compare
|
Could this change be also applied to 1.12 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2205 introduced a regression on detours for unconventional calling functions.
This does not help (I've to avoid saying 'close') #2212 as it's a different issue, however it's in that same thread that the present regression was reported. Thanks to @jensewe for spotting the issue, and thanks to @FortyTwoFortyTwo for case-testing this.