This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Metrics: "training_duration" does not include day count #2717
Comments
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this issue
Nov 12, 2019
…ai#2718) * Added default predictor for bimpm model * Fix allenai#2717: Add day count in training duration This fixes Issue [@2717](allenai#2717) to include day count in `training_duration` key in metrics. * Modify elapsed time format to use `timedelta` `time.strftime` does not account for number of days more than 31. Changing it to `datetime.timedelta` and using its `str` representation for printing epoch duration as well as training duration.
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this issue
Feb 20, 2020
…ai#2718) * Added default predictor for bimpm model * Fix allenai#2717: Add day count in training duration This fixes Issue [@2717](allenai#2717) to include day count in `training_duration` key in metrics. * Modify elapsed time format to use `timedelta` `time.strftime` does not account for number of days more than 31. Changing it to `datetime.timedelta` and using its `str` representation for printing epoch duration as well as training duration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When the training duration gets longer than a day, the
metrics.jsonmisses to include the day count and only has "hh:mm:ss". It should rather have "dd:hh:mm:ss".The text was updated successfully, but these errors were encountered: