SKYEDEN-3020 | consumers retransmission improvements #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9981d34 to
b304b45
Compare
…erRetransmissionImprovements # Conflicts: # hermes-consumers/src/main/java/pl/allegro/tech/hermes/consumers/consumer/receiver/MessageReceiver.java
szczygiel-m
reviewed
Jan 9, 2025
| if (!movedOffsets.isEmpty()) { | ||
| // Incrementing assignment term ensures that currently committed offsets won't be overwritten | ||
| // by the events from the past which are concurrently processed by the consumer | ||
| partitionAssignmentState.incrementTerm(subscriptionName); |
There was a problem hiding this comment.
Are You sure that this is the correct order to commit first and then increment assignment term?
There was a problem hiding this comment.
Order doesn't matter in this case. Even though the events are processed concurrently, the commitment of offsets is synchronous. The method commitIfReady can only be executed when the entire process of retransmission is complete.
szczygiel-m
previously approved these changes
Jan 9, 2025
moscicky
previously approved these changes
Jan 9, 2025
…erRetransmissionImprovements # Conflicts: # integration-tests/src/integrationTest/java/pl/allegro/tech/hermes/integrationtests/KafkaRetransmissionServiceTest.java
4e2865e
moscicky
approved these changes
Jan 10, 2025
moscicky
approved these changes
Jan 10, 2025
szczygiel-m
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current retransmission process, offsets are updated only locally in Hermes consumers via
KafkaConsumer::seek().This pull request introduces a change to also commit offsets to Kafka using
KafkaConsumer::commitSync().Furthermore, it increments the partitionAssignmentTerm to ensure Kafka-committed offsets are not overwritten by concurrently processed events created before retransmission.