Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements around service scalability #41

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

valeksiev
Copy link
Collaborator

@valeksiev valeksiev commented Jul 4, 2024

Describe the background of your pull request

  • move batch size to env var with a default of 20
  • base winston log level on the LOGGING_LEVEL variable and ensure it is lowercase
  • auto ack messages when received

Additional context

Fixes: #38

Governance

  • Documentation is added
  • Test cases are added or updated

By submitting this pull request I confirm that:

base winston log level on LOGGING_LEVEL variable and ensure its lower case
auto ack messages on receival
@valeksiev valeksiev requested review from hero101 and techsmyth July 4, 2024 15:25
Copy link
Contributor

@hero101 hero101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment - with message being auto ack, the service can still hang, at least we will know it's not because of message order

src/ingest.ts Outdated Show resolved Hide resolved
src/logger.ts Outdated Show resolved Hide resolved
@hero101 hero101 merged commit 978eff4 into develop Jul 5, 2024
@hero101 hero101 deleted the no-ack-messages-improved-logging branch July 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Ingestion times out and continuously crashes the ingestion containers
2 participants