Licensing setup; initial framework for interaction with Wingback #4115
Conversation
|
Warning Rate limit exceeded@valentinyanakiev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 39 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (20)
WalkthroughThe changes in this pull request introduce significant updates to the licensing framework within the Alkemio platform. A new Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Outside diff range and nitpick comments (36)
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.resolver.mutations.ts (4)
22-22: Consider addressing the TODO comment.There's a TODO comment indicating that this code may need to be moved. Please ensure all TODOs are resolved or tracked before merging.
Would you like me to create a GitHub issue to track this task?
54-54: Consider addressing the TODO comment.There's a TODO comment indicating that this code may need to be moved. Please ensure all TODOs are resolved or tracked before merging.
Would you like me to create a GitHub issue to track this task?
27-27: Specify explicit return type for the method.For better type safety and readability, consider specifying an explicit return type for the
adminWingbackCreateTestCustomermethod.Apply this diff to add the return type:
@Mutation(() => String, { description: 'Create a test customer on wingback.', }) -public async adminWingbackCreateTestCustomer( +public async adminWingbackCreateTestCustomer( @CurrentUser() agentInfo: AgentInfo +): Promise<string> {
59-59: Specify explicit return type for the method.For better type safety and readability, consider specifying an explicit return type for the
adminWingbackGetCustomerEntitlementsmethod.Apply this diff to add the return type:
@Mutation(() => String, { description: 'Get wingback customer entitlements.', }) -public async adminWingbackGetCustomerEntitlements( +public async adminWingbackGetCustomerEntitlements( @Args('customerID') customerId: string, @CurrentUser() agentInfo: AgentInfo +): Promise<string> {src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.ts (1)
Line range hint
96-96: Fix the typo in method namegetDefaultLicensePollicyOrFail.The method name
getDefaultLicensePollicyOrFailcontains a typo. It should begetDefaultLicensePolicyOrFail.Apply this diff to correct the method name:
-private async getDefaultLicensePollicyOrFail( +private async getDefaultLicensePolicyOrFail( licensePolicy?: ILicensePolicy | undefined ): Promise<ILicensePolicy> {Also, update all references to this method accordingly.
src/domain/space/space/space.service.ts (1)
109-109: Rename property for consistency with injected service.The property
licenseEngineServiceshould be renamed tolicensingCredentialBasedServiceto match the injected service and improve code clarity.Apply this diff to rename the property:
-private licenseEngineService: LicensingCredentialBasedService, +private licensingCredentialBasedService: LicensingCredentialBasedService,Remember to update all references to this property within the class.
src/services/external/wingback/wingback.manager.module.ts (1)
1-10: LGTM! Consider injecting configuration.The module structure follows NestJS best practices. However, since this is an external service integration, consider injecting the Wingback configuration using the
@nestjs/configpackage'sConfigService.Example implementation:
import { Module } from '@nestjs/common'; import { HttpModule } from '@nestjs/axios'; import { WingbackManager } from './wingback.manager'; +import { ConfigModule } from '@nestjs/config'; @Module({ - imports: [HttpModule], + imports: [ + HttpModule, + ConfigModule.forFeature(() => ({ + wingback: { + // your wingback config schema + } + })) + ], providers: [WingbackManager], exports: [WingbackManager], }) export class WingbackManagerModule {}src/services/external/wingback/types/wingback.type.entitlement.ts (1)
1-16: Add JSDoc documentation.Consider adding JSDoc comments to document the purpose and structure of the WingbackEntitlement type and its properties.
Example implementation:
import { WingbackFeature } from './wingback.type.feature'; +/** + * Represents an entitlement from the Wingback service + * @property customer - Customer information including their status + * @property contract - Contract details including ID and status + * @property plan - Plan information including features + */ export type WingbackEntitlement = {src/common/enums/licensing.credental.based.plan.type.ts (1)
10-12: Add enum description in GraphQL registration.Consider adding a description field to the GraphQL enum registration to improve API documentation.
registerEnumType(LicensingCredentialBasedPlanType, { name: 'LicensingCredentialBasedPlanType', + description: 'Types of credential-based licensing plans available in the system', });src/common/enums/licensing.wingback.subscription.feature.name.ts (1)
3-7: Consider using consistent casing between enum keys and values.The enum keys use SCREAMING_SNAKE_CASE while the values use kebab-case. This inconsistency might lead to confusion. Consider using consistent casing, preferably SCREAMING_SNAKE_CASE for both:
export enum LicensingWingbackSubscriptionFeatureName { - ACCOUNT_SPACE_FREE = 'account-space-free', - ACCOUNT_SPACE_PLUS = 'account-space-plus', - ACCOUNT_SPACE_PREMIUM = 'account-space-premium', + ACCOUNT_SPACE_FREE = 'ACCOUNT_SPACE_FREE', + ACCOUNT_SPACE_PLUS = 'ACCOUNT_SPACE_PLUS', + ACCOUNT_SPACE_PREMIUM = 'ACCOUNT_SPACE_PREMIUM', }src/services/external/wingback/types/wingback.type.feature.ts (1)
1-14: Consider adding JSDoc comments for better documentation.The
WingbackFeaturetype represents a complex structure from an external API. Adding JSDoc comments would help developers understand:
- The purpose of each field
- The expected format/constraints
- Example values
src/common/enums/credential.type.ts (1)
10-12: Consider adding JSDoc documentation for the union type.While the type definition is correct, adding JSDoc documentation would help explain the distinction between credential-based and authorization-based types.
+/** + * Represents the combined credential types supported by the system. + * Includes both licensing credential-based and authorization-based types. + */ export type CredentialType = | LicensingCredentialBasedCredentialType | AuthorizationCredential;src/domain/space/account/account.license.subscription.interface.ts (1)
Line range hint
1-17: Consider creating a base subscription interface.There's significant duplication between
IAccountSubscriptionandISpaceSubscription. Consider extracting the common fields into a base interface.@ObjectType('BaseSubscription', { isAbstract: true }) export abstract class IBaseSubscription { @Field(() => LicensingCredentialBasedCredentialType, { description: 'The name of the Subscription.', }) name!: LicensingCredentialBasedCredentialType; @Field(() => Date, { nullable: true, description: 'The expiry date of this subscription, null if it does never expire.', }) expires?: Date; } @ObjectType('AccountSubscription') export abstract class IAccountSubscription extends IBaseSubscription {} @ObjectType('SpaceSubscription') export abstract class ISpaceSubscription extends IBaseSubscription {}src/common/enums/licensing.credental.based.credential.type.ts (2)
Line range hint
4-13: Consider separating license types and feature flagsThe enum mixes two different concerns:
- License tiers (FREE, PLUS, PREMIUM, ENTERPRISE)
- Feature flags (SAVE_AS_TEMPLATE, VIRTUAL_CONTRIBUTORS, etc.)
Consider splitting these into separate enums for better maintainability:
LicensingCredentialBasedLicenseTypeLicensingCredentialBasedFeatureType
Line range hint
1-18: Fix typo in filenameThe filename contains a typo: 'credental' should be 'credential'
Rename the file from:
licensing.credental.based.credential.type.ts
to:
licensing.credential.based.credential.type.tssrc/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.ts (1)
12-20: Consider adding input validation and maintaining consistent property order.The implementation could be enhanced in two ways:
- Add validation for empty arrays and strings
- Match the constructor parameter order with the property declaration order (credentialType, grantedEntitlements, name)
constructor( - grantedEntitlements: LicenseEntitlementType[], credentialType: LicensingCredentialBasedCredentialType, + grantedEntitlements: LicenseEntitlementType[], name: string ) { + if (!grantedEntitlements.length) { + throw new Error('grantedEntitlements cannot be empty'); + } + if (!name.trim()) { + throw new Error('name cannot be empty'); + } this.credentialType = credentialType; this.grantedEntitlements = grantedEntitlements; this.name = name; }src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.ts (2)
14-16: Add input validation for createCustomer.The method should validate the input data before passing it to the wingbackManager.
public createCustomer(data: CreateCustomer): Promise<{ id: string } | never> { + if (!data.email?.trim()) { + throw new Error('Customer email is required'); + } return this.wingbackManager.createCustomer(data); }
9-13: Enhance error documentation.The JSDoc comment should specify what types of errors can be thrown and under what conditions.
/** * Create a new customer * @param data - * @throws {Error} if the request fails + * @throws {ValidationError} if the customer data is invalid + * @throws {WingbackApiError} if the Wingback API request fails + * @throws {NetworkError} if there are connectivity issues */src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.spec.ts (1)
Line range hint
7-26: Add test coverage for service methods.The test suite only verifies service instantiation. Consider adding test cases for:
- Credential validation
- Entitlement granting logic
- Error handling scenarios
Example test cases to add:
it('should validate credentials correctly', () => { // Test implementation }); it('should grant correct entitlements based on credentials', () => { // Test implementation }); it('should handle invalid credentials appropriately', () => { // Test implementation });src/platform/licensing/wingback-subscription/licensing.wingback.subscription.module.ts (1)
1-20: LGTM! Consider adding module documentation.The module structure follows NestJS best practices with proper dependency imports and clear separation of concerns. The use of path aliases and consistent naming conventions is good.
Consider adding JSDoc documentation to describe the module's purpose and responsibilities:
+/** + * Module responsible for managing Wingback subscription-based licensing. + * Provides integration with Wingback services and maps their responses to Alkemio entitlements. + */ @Module({ imports: [ WingbackManagerModule,src/platform/licensing/credential-based/license-policy/license.policy.module.ts (1)
8-14: LGTM! Consider adding module documentation.The module structure and dependency injection follow NestJS best practices. The change from
LicenseEngineModuletoLicensingCredentialBasedModulealigns well with the PR objectives of separating license entitlements.Consider adding a JSDoc comment to document the module's purpose and responsibilities:
/** * Module handling license policy management and authorization. * Integrates with credential-based licensing for entitlements. */ @Module({src/services/external/wingback/types/wingback.type.create.customer.ts (1)
36-36: Type safety: Specify contracts array type.The
contractsproperty usesunknown[]which loses type safety. Consider defining a proper interface for the contract type.interface WingbackContract { // Define contract properties } export type CreateCustomer = { // ... contracts?: WingbackContract[]; };src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.update.ts (1)
3-3: Consider adding input validation for the credential type.While the type change to
LicensingCredentialBasedCredentialTypeis correct, consider adding class-validator decorators for additional runtime validation.Add validation like this:
@Field(() => LicensingCredentialBasedCredentialType, { description: 'The credential to represent this plan', nullable: true, }) + @IsEnum(LicensingCredentialBasedCredentialType) + @IsOptional() licenseCredential?: LicensingCredentialBasedCredentialType;Also applies to: 49-53
src/platform/licensing/credential-based/license-plan/license.plan.entity.ts (1)
4-5: Consider adding database enum constraints for credential and plan types.While the type changes are correct, consider adding enum constraints at the database level for better data integrity.
Update the column decorators like this:
- @Column('text', { nullable: false }) + @Column({ + type: 'enum', + enum: LicensingCredentialBasedCredentialType, + nullable: false + }) licenseCredential!: LicensingCredentialBasedCredentialType; - @Column('varchar', { nullable: false, length: ENUM_LENGTH }) + @Column({ + type: 'enum', + enum: LicensingCredentialBasedPlanType, + nullable: false + }) type!: LicensingCredentialBasedPlanType;Also applies to: 43-43, 46-46
src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.create.ts (2)
40-44: Consider adding validation for enum valuesWhile the type is properly defined, consider adding @IsEnum() validation to ensure the input value matches the enum.
@Field(() => LicensingCredentialBasedPlanType, { nullable: false, description: 'The type of this License Plan.', }) + @IsEnum(LicensingCredentialBasedPlanType) type!: LicensingCredentialBasedPlanType;
64-68: Add validation for credential typeSimilar to the plan type, add enum validation for the credential type.
@Field(() => LicensingCredentialBasedCredentialType, { description: 'The credential to represent this plan', nullable: false, }) + @IsEnum(LicensingCredentialBasedCredentialType) licenseCredential!: LicensingCredentialBasedCredentialType;src/platform/licensing/credential-based/license-plan/license.plan.interface.ts (2)
29-33: Consider marking type field as non-nullable in GraphQL schemaThe field is marked as non-nullable in TypeScript, but for better GraphQL schema clarity, consider adding the non-null operator to the type reference.
- @Field(() => LicensingCredentialBasedPlanType, { + @Field(() => LicensingCredentialBasedPlanType!, { nullable: false, description: 'The type of this License Plan.', }) type!: LicensingCredentialBasedPlanType;
65-69: Consider marking licenseCredential field as non-nullable in GraphQL schemaSimilar to the type field, consider adding the non-null operator for better GraphQL schema clarity.
- @Field(() => LicensingCredentialBasedCredentialType, { + @Field(() => LicensingCredentialBasedCredentialType!, { description: 'The credential to represent this plan', nullable: false, }) licenseCredential!: LicensingCredentialBasedCredentialType;src/platform/licensing/credential-based/license-policy/license.policy.service.ts (1)
60-62: Consider adding input validationWhile the return type change is correct, consider adding validation for
license.credentialRulesStrbefore passing it toconvertCredentialRulesStr.getCredentialRules( license: ILicensePolicy ): ILicensingCredentialBasedPolicyCredentialRule[] { + if (!license?.credentialRulesStr) { + return []; + } const rules = this.licenseEngineService.convertCredentialRulesStr( license.credentialRulesStr ); return rules; }src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.ts (1)
Line range hint
71-86: Consider enhancing error handling for license plan validation.While the error handling is generally good, consider adding specific validation for license plan properties before saving.
public async createLicensePlan( licensePlanData: CreateLicensePlanOnLicensingFrameworkInput ): Promise<ILicensePlan> { const licensing = await this.getLicensingOrFail( licensePlanData.licensingFrameworkID, { relations: { plans: true, }, } ); if (!licensing.plans) throw new EntityNotInitializedException( `Licensing (${licensing}) not initialised`, LogContext.LICENSE ); + // Validate license plan data before creation + if (!licensePlanData.name || !licensePlanData.description) { + throw new Error('License plan requires name and description'); + } const licensePlan = await this.licensePlanService.createLicensePlan(licensePlanData); licensing.plans.push(licensePlan); await this.licensingFrameworkRepository.save(licensing); return licensePlan; }src/domain/space/account/account.service.license.ts (2)
11-11: Consider using a barrel import for licensing modulesThe import path is quite long and could be simplified using a barrel file.
Consider creating an index.ts file in the licensing directory and updating the import:
-import { LicensingCredentialBasedService } from '@platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service'; +import { LicensingCredentialBasedService } from '@platform/licensing';
Line range hint
67-142: Consider refactoring entitlement checks to reduce duplicationThe switch statement contains repeated patterns for each entitlement type, which could be refactored to reduce code duplication.
Consider creating a map of entitlement types to their limits and using a helper function:
+private readonly ENTITLEMENT_LIMITS = new Map([ + [LicenseEntitlementType.ACCOUNT_SPACE_FREE, 3], + [LicenseEntitlementType.ACCOUNT_SPACE_PLUS, 0], + [LicenseEntitlementType.ACCOUNT_SPACE_PREMIUM, 0], + [LicenseEntitlementType.ACCOUNT_VIRTUAL_CONTRIBUTOR, 3], + [LicenseEntitlementType.ACCOUNT_INNOVATION_HUB, 1], + [LicenseEntitlementType.ACCOUNT_INNOVATION_PACK, 3], +]); + +private async processEntitlement( + entitlement: IEntitlement, + accountAgent: IAgent +): Promise<void> { + const limit = this.ENTITLEMENT_LIMITS.get(entitlement.type); + if (limit === undefined) { + throw new EntityNotInitializedException( + `Unknown entitlement type: ${entitlement.type}`, + LogContext.LICENSE + ); + } + const isGranted = await this.licenseEngineService.isEntitlementGranted( + entitlement.type, + accountAgent + ); + if (isGranted) { + entitlement.limit = limit; + entitlement.enabled = true; + } +}src/types/alkemio.config.ts (1)
36-42: Add JSDoc comments for the licensing configurationThe new licensing configuration section would benefit from documentation explaining the purpose and requirements of each field.
Add JSDoc comments to improve configuration clarity:
+ /** + * Configuration for licensing features + */ licensing: { + /** + * Wingback integration configuration + */ wingback: { + /** Enable/disable Wingback integration */ enabled: boolean; + /** API key for Wingback service authentication */ key: string; + /** Wingback service endpoint URL */ endpoint: string; }; };src/domain/space/space/space.service.license.ts (2)
Line range hint
91-166: Extract common entitlement handling logicThe entitlement handling logic is very similar to the account service, suggesting an opportunity for code reuse.
Consider creating a shared service for entitlement handling:
+@Injectable() +export class EntitlementHandlerService { + constructor( + private licenseEngineService: LicensingCredentialBasedService + ) {} + + async processEntitlement( + entitlement: IEntitlement, + agent: IAgent, + limit: number + ): Promise<void> { + const isGranted = await this.licenseEngineService.isEntitlementGranted( + entitlement.type, + agent + ); + if (isGranted) { + entitlement.limit = limit; + entitlement.enabled = true; + } + } +}This would reduce duplication between account and space services while maintaining type safety and error handling.
Line range hint
28-89: Consider adding validation for recursive depthThe recursive license policy application for subspaces could potentially cause stack overflow with deeply nested spaces.
Consider adding a depth limit parameter and validation:
async applyLicensePolicy( spaceID: string, - level0SpaceAgent?: IAgent + level0SpaceAgent?: IAgent, + depth: number = 0 ): Promise<ILicense[]> { + const MAX_DEPTH = 100; // Adjust based on your needs + if (depth > MAX_DEPTH) { + throw new Error(`Maximum space nesting depth of ${MAX_DEPTH} exceeded`); + } // ... existing code ... for (const subspace of space.subspaces) { const subspaceLicenses = await this.applyLicensePolicy( subspace.id, - rootLevelSpaceAgent + rootLevelSpaceAgent, + depth + 1 ); updatedLicenses.push(...subspaceLicenses); }src/domain/space/account/account.service.ts (1)
370-376: Consider optimizing the credential type checkThe current implementation using
Object.values()andincludes()could be optimized for better performance, especially when dealing with multiple credentials.Consider this more efficient approach:
-if ( - Object.values(LicensingCredentialBasedCredentialType).includes( - credential.type as LicensingCredentialBasedCredentialType - ) -) { +const isLicensingCredential = (type: string): type is LicensingCredentialBasedCredentialType => { + return type in LicensingCredentialBasedCredentialType; +}; + +if (isLicensingCredential(credential.type)) { subscriptions.push({ - name: credential.type as LicensingCredentialBasedCredentialType, + name: credential.type, expires: credential.expires, }); }This approach:
- Provides better type safety with a type guard
- Avoids repeated
Object.values()calls- Eliminates the need for type assertion
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (70)
alkemio.yml(1 hunks)src/app.module.ts(2 hunks)src/common/enums/credential.type.ts(1 hunks)src/common/enums/licensing.credental.based.credential.type.ts(2 hunks)src/common/enums/licensing.credental.based.plan.type.ts(1 hunks)src/common/enums/licensing.wingback.subscription.feature.name.ts(1 hunks)src/core/bootstrap/bootstrap.module.ts(1 hunks)src/core/bootstrap/bootstrap.service.ts(1 hunks)src/core/license-engine/index.ts(0 hunks)src/core/license-engine/license.engine.module.ts(0 hunks)src/core/license-engine/license.policy.rule.credential.interface.ts(0 hunks)src/core/license-engine/license.policy.rule.credential.ts(0 hunks)src/domain/in-app-notification-reader/dto/in.app.notification.community.new.member.ts(0 hunks)src/domain/in-app-notification-reader/dto/in.app.notification.user.mentioned.ts(0 hunks)src/domain/space/account.host/account.host.module.ts(1 hunks)src/domain/space/account.host/account.host.service.ts(2 hunks)src/domain/space/account/account.license.subscription.interface.ts(1 hunks)src/domain/space/account/account.module.ts(3 hunks)src/domain/space/account/account.service.license.ts(2 hunks)src/domain/space/account/account.service.ts(2 hunks)src/domain/space/space/space.license.subscription.interface.ts(1 hunks)src/domain/space/space/space.module.ts(2 hunks)src/domain/space/space/space.service.license.ts(2 hunks)src/domain/space/space/space.service.ts(5 hunks)src/migrations/1733732413139-inAppNotifications.ts(2 hunks)src/platform/admin/licensing/admin.licensing.module.ts(1 hunks)src/platform/admin/licensing/admin.licensing.resolver.mutations.ts(1 hunks)src/platform/admin/licensing/admin.licensing.service.ts(5 hunks)src/platform/licensing/credential-based/license-credential-issuer/license.issuer.service.ts(1 hunks)src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.create.ts(3 hunks)src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.update.ts(2 hunks)src/platform/licensing/credential-based/license-plan/license.plan.entity.ts(2 hunks)src/platform/licensing/credential-based/license-plan/license.plan.interface.ts(3 hunks)src/platform/licensing/credential-based/license-plan/license.plan.resolver.mutations.ts(1 hunks)src/platform/licensing/credential-based/license-policy/license.policy.module.ts(1 hunks)src/platform/licensing/credential-based/license-policy/license.policy.resolver.fields.ts(1 hunks)src/platform/licensing/credential-based/license-policy/license.policy.service.ts(2 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/index.ts(1 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.module.ts(1 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.interface.ts(1 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.ts(1 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.spec.ts(1 hunks)src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.ts(5 hunks)src/platform/licensing/credential-based/licensing-framework/dto/licensing.framework.dto.create.license.plan.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.entity.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.interface.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.module.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.resolver.fields.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.resolver.mutations.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.authorization.ts(1 hunks)src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.ts(1 hunks)src/platform/licensing/wingback-subscription/licensing.wingback.subscription.module.ts(1 hunks)src/platform/licensing/wingback-subscription/licensing.wingback.subscription.resolver.mutations.ts(1 hunks)src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.spec.ts(1 hunks)src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.ts(1 hunks)src/platform/platform.role/platform.role.service.ts(3 hunks)src/platform/platform/platform.entity.ts(1 hunks)src/platform/platform/platform.interface.ts(1 hunks)src/platform/platform/platform.module.ts(1 hunks)src/platform/platform/platform.resolver.fields.ts(1 hunks)src/platform/platform/platform.service.authorization.ts(1 hunks)src/platform/platform/platform.service.ts(1 hunks)src/services/external/wingback/index.ts(1 hunks)src/services/external/wingback/types/wingback.type.create.customer.ts(1 hunks)src/services/external/wingback/types/wingback.type.entitlement.ts(1 hunks)src/services/external/wingback/types/wingback.type.feature.ts(1 hunks)src/services/external/wingback/types/wingback.type.update.customer.ts(1 hunks)src/services/external/wingback/wingback.manager.module.ts(1 hunks)src/services/external/wingback/wingback.manager.ts(1 hunks)src/types/alkemio.config.ts(1 hunks)
💤 Files with no reviewable changes (6)
- src/core/license-engine/index.ts
- src/core/license-engine/license.policy.rule.credential.ts
- src/core/license-engine/license.policy.rule.credential.interface.ts
- src/core/license-engine/license.engine.module.ts
- src/domain/in-app-notification-reader/dto/in.app.notification.community.new.member.ts
- src/domain/in-app-notification-reader/dto/in.app.notification.user.mentioned.ts
✅ Files skipped from review due to trivial changes (18)
- src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/index.ts
- src/services/external/wingback/index.ts
- src/platform/platform/platform.entity.ts
- src/platform/licensing/credential-based/licensing-framework/licensing.framework.resolver.mutations.ts
- src/platform/platform/platform.service.authorization.ts
- src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.module.ts
- src/platform/licensing/credential-based/license-credential-issuer/license.issuer.service.ts
- src/platform/licensing/credential-based/licensing-framework/licensing.framework.interface.ts
- src/migrations/1733732413139-inAppNotifications.ts
- src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.authorization.ts
- src/platform/platform/platform.service.ts
- src/platform/licensing/credential-based/licensing-framework/licensing.framework.module.ts
- src/platform/licensing/credential-based/licensing-framework/licensing.framework.entity.ts
- src/platform/admin/licensing/admin.licensing.module.ts
- src/platform/admin/licensing/admin.licensing.resolver.mutations.ts
- src/services/external/wingback/types/wingback.type.update.customer.ts
- src/domain/space/account.host/account.host.service.ts
- src/platform/licensing/credential-based/license-plan/license.plan.resolver.mutations.ts
🧰 Additional context used
📓 Path-based instructions (45)
src/platform/platform/platform.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-policy/license.policy.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-framework/dto/licensing.framework.dto.create.license.plan.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/common/enums/licensing.wingback.subscription.feature.name.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/platform/platform.interface.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/common/enums/credential.type.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/platform/platform.resolver.fields.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.spec.ts (2)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
Pattern src/**/*.spec.ts: Review the unit tests, ensuring proper NestJS testing techniques (using TestingModule, mocks, etc.). Check for completeness and coverage.
src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.update.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/common/enums/licensing.credental.based.plan.type.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/space/space.service.license.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/account/account.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/account/account.license.subscription.interface.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.spec.ts (2)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
Pattern src/**/*.spec.ts: Review the unit tests, ensuring proper NestJS testing techniques (using TestingModule, mocks, etc.). Check for completeness and coverage.
src/services/external/wingback/wingback.manager.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/services/external/wingback/types/wingback.type.feature.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/types/alkemio.config.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/account.host/account.host.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/app.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/core/bootstrap/bootstrap.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/space/space.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/platform.role/platform.role.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/services/external/wingback/types/wingback.type.entitlement.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-plan/dto/license.plan.dto.create.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.module.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/core/bootstrap/bootstrap.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/account/account.service.license.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/common/enums/licensing.credental.based.credential.type.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-framework/licensing.framework.resolver.fields.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-policy/license.policy.resolver.fields.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-plan/license.plan.interface.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.interface.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-plan/license.plan.entity.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/space/space.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/account/account.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/admin/licensing/admin.licensing.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.resolver.mutations.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/domain/space/space/space.license.subscription.interface.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/services/external/wingback/types/wingback.type.create.customer.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/license-policy/license.policy.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.service.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
src/services/external/wingback/wingback.manager.ts (1)
Pattern src/**/*.{ts,js}: Review the TypeScript/JavaScript code for NestJS best practices, dependency injection, module structure, and potential bugs.
Context Files (Do Not Review):
docs/Design.md- Design overview of the projectdocs/Pagination.md- Pagination design overviewdocs/Developing.md- Development setup overviewdocs/graphql-typeorm-usage.md- overview of GraphQL and TypeORM usage and how they are used together with NestJS in the projectdocs/database-definitions.md- guidelines for creating TypeORM entity defnitionssrc/core/error-handling/graphql.exception.filter.ts- GraphQL error handlingsrc/core/error-handling/http.exception.filter.ts- HTTP error handlingsrc/core/error-handling/rest.error.response.ts- REST error responsesrc/core/error-handling/unhandled.exception.filter.ts- Global exception handler
Guidelines:
- Our project uses global exception handlers (
UnhandledExceptionFilter), so avoid suggesting additionaltry/catchblocks unless handling specific cases. - Use NestJS latest documentation from
https://docs.nestjs.com/for reference on NestJS best practices. - Use TypeORM latest documentation from
https://typeorm.io/for reference on TypeORM best practices. - Refer to the design overview in the context files for better understanding.
🔇 Additional comments (31)
src/domain/space/space/space.service.ts (1)
920-925: Ensure type safety when casting credential types.
When casting credential.type to LicensingCredentialBasedCredentialType, ensure that credential.type is indeed a valid value. This prevents potential runtime errors.
Run the following script to verify all credential types:
src/services/external/wingback/types/wingback.type.entitlement.ts (1)
4-6: Consider expanding status field types.
The status fields are currently constrained to 'active', but they might need to handle other states (e.g., 'inactive', 'suspended'). Consider using a union type or enum to support future status values.
Example implementation:
+export type WingbackStatus = 'active' | 'inactive' | 'suspended';
+
export type WingbackEntitlement = {
customer: {
- status: 'active';
+ status: WingbackStatus;
};
contract: {
contract_id: string;
- status: 'active';
+ status: WingbackStatus;
};Also applies to: 8-10
src/platform/licensing/credential-based/licensing-framework/dto/licensing.framework.dto.create.license.plan.ts (1)
Line range hint 1-11: LGTM! The DTO structure follows NestJS best practices.
The import path update aligns with the PR's objective of refactoring licensing components, and the class properly extends the base input while adding a strongly-typed UUID field.
src/services/external/wingback/types/wingback.type.feature.ts (1)
8-12:
Improve type safety by properly typing the 'unknown' fields.
Several fields are typed as unknown, which could lead to runtime issues:
batch_size: unknown | nullflat_fee: unknown | nulltiers: unknown[]
Consider:
- Defining proper types based on the Wingback API contract
- Adding type guards if the types are truly dynamic
Let's verify the Wingback API contract:
src/common/enums/credential.type.ts (1)
2-2: LGTM! Clean enum composition using spread operator.
The refactoring from LicenseCredential to LicensingCredentialBasedCredentialType maintains proper type safety while clearly indicating the credential's purpose.
Also applies to: 6-8
src/domain/space/space/space.license.subscription.interface.ts (1)
1-1: LGTM! Well-structured GraphQL object type definition.
The update to use LicensingCredentialBasedCredentialType maintains type safety while providing clear GraphQL schema documentation. The field descriptions are helpful for API consumers.
Also applies to: 6-9
src/domain/space/account/account.license.subscription.interface.ts (1)
1-1: LGTM! Consistent with space subscription interface.
The changes maintain consistency with the space subscription interface and follow NestJS best practices.
Also applies to: 6-9
src/common/enums/licensing.credental.based.credential.type.ts (1)
Line range hint 8-8: Address TODO comment about enterprise license
The comment indicates that the enterprise license should be removed for space. Please clarify:
- When will this be removed?
- Are there any dependencies to consider?
- Should this be tracked in a separate issue?
src/platform/licensing/credential-based/license-policy/license.policy.resolver.fields.ts (1)
4-4: LGTM! Verify new credential rule type.
The resolver field is properly typed and documented. The change aligns with the PR objective of separating license entitlements.
Let's verify the new credential rule type is properly exported:
Also applies to: 10-21
✅ Verification successful
Interface is properly defined and used consistently
The ILicensingCredentialBasedPolicyCredentialRule interface is properly defined in licensing-credential-based-entitlements-engine/licensing.credential.based.policy.rule.credential.interface.ts and is correctly exported. It's being used consistently across the codebase:
- Defined as an abstract class with
@ObjectTypedecorator for GraphQL - Implemented by
LicensingCredentialBasedPolicyCredentialRuleclass - Used in multiple services including
LicensePolicyServiceandLicensingCredentialBasedService - Correctly imported in the resolver file under review
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the new credential rule type exists and is exported
# Check if the interface is properly exported
ast-grep --pattern 'export interface ILicensingCredentialBasedPolicyCredentialRule'
# Check for any references to the old interface that might need updating
rg "ILicensePolicyCredentialRule" --type ts
Length of output: 129
Script:
#!/bin/bash
# Let's try a broader search to locate the interface definition and its usage
# Search for any file containing "CredentialBasedPolicyCredentialRule"
rg "CredentialBasedPolicyCredentialRule" --type ts -A 5
# Find all TypeScript files in the licensing directory to understand the structure
fd -e ts -p licensing
# Search for any credential rule related interfaces
rg "interface.*CredentialRule" --type ts -A 5
Length of output: 13830
src/domain/space/account.host/account.host.module.ts (1)
4-4: Verify consistent import path updates across codebase.
The import path updates align with the new licensing code organization.
Let's verify all licensing imports are consistently updated:
Also applies to: 9-9
✅ Verification successful
Import paths have been consistently updated across the codebase
The verification shows that all licensing-related imports are using the new paths under @platform/licensing/credential-based/. No instances of old import paths were found, and the new structure is consistently used across all relevant files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining old import paths that need updating
# Check for old license-issuer imports
rg "@platform/license-issuer/license\.issuer\.module" --type ts
# Check for old licensing-framework imports
rg "@platform/licensing-framework/licensing\.framework\.module" --type ts
# Check the new import paths are used consistently
rg "@platform/licensing/credential-based/(license-credential-issuer|licensing-framework)" --type ts
Length of output: 4722
src/platform/platform/platform.interface.ts (1)
10-10: LGTM! Import path update aligns with new structure.
The updated import path correctly reflects the new credential-based licensing structure, maintaining consistency with the PR's objective of separating license entitlements.
src/platform/licensing/credential-based/licensing-framework/licensing.framework.resolver.fields.ts (1)
8-9: LGTM! Import paths correctly reflect the new credential-based structure.
The updated import paths align with the PR objectives of separating credential-based licensing components.
Let's verify the consistency of the new import paths across the codebase:
✅ Verification successful
Import paths are consistently used across the codebase
The verification shows that the new credential-based import paths for license-plan and license-policy are consistently used across all relevant files in the codebase, including services, modules, resolvers, and entities. The imports in the file under review align with this consistent pattern.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify consistent usage of new credential-based import paths
rg -g '*.ts' '@platform/licensing/credential-based/(license-plan|license-policy)'
Length of output: 4549
src/platform/licensing/credential-based/license-plan/license.plan.entity.ts (1)
7-7: LGTM! Import path correctly reflects the new credential-based structure.
The updated import path for LicensingFramework aligns with the PR objectives.
src/platform/platform/platform.module.ts (1)
19-19: Verify consistent usage of the new import path across the codebase
The import path has been updated to reflect the new credential-based licensing structure.
✅ Verification successful
Import path changes are consistent across the codebase
The search results confirm that all imports of LicensingFrameworkModule consistently use the new path @platform/licensing/credential-based/licensing-framework/licensing.framework.module. No instances of the old import path were found, indicating successful refactoring across all dependent modules.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining old import paths
# and verify consistent usage of the new path
# Search for old import path
rg "@platform/licensing-framework/licensing\.framework\.module"
# Search for new import path usage
rg "@platform/licensing/credential-based/licensing-framework/licensing\.framework\.module"
Length of output: 1196
src/platform/licensing/credential-based/license-policy/license.policy.service.ts (2)
26-28: Type safety improvement in createCredentialRule
The parameter type change from LicenseCredential to LicensingCredentialBasedCredentialType improves type safety by being more specific to the credential-based implementation.
8-11: Verify service dependency replacement impact
The switch from LicenseEngineService to LicensingCredentialBasedService represents a significant architectural change. While the change aligns with the new credential-based structure, we should verify all callers are updated.
Also applies to: 19-19
✅ Verification successful
Let me analyze the results. The search shows that:
- There are no remaining references to the old
LicenseEngineService - The new
LicensingCredentialBasedServiceis properly:- Defined in its own module and service files
- Exported from the module
- Used consistently across the codebase in space and account services
Let me generate the final response:
Service dependency replacement is complete and consistent ✓
All service dependencies have been properly updated to use LicensingCredentialBasedService. No remaining references to the old LicenseEngineService were found, and the new service is consistently used across the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining references to LicenseEngineService
rg "LicenseEngineService"
# Search for usage patterns of the new service
rg "LicensingCredentialBasedService"
Length of output: 2934
src/core/bootstrap/bootstrap.module.ts (1)
24-25: Import paths correctly updated
The import path changes properly reflect the new credential-based module structure. The module organization is now more explicit about its purpose.
src/domain/space/account/account.module.ts (2)
17-17: Module imports correctly aligned with new structure
The import path changes properly reflect the new credential-based licensing structure. The module dependencies are correctly organized.
Also applies to: 19-19, 28-28
42-42: Verify module initialization order
The LicensingCredentialBasedModule is correctly added to the imports array. However, consider if there are any initialization dependencies between the licensing modules that might require a specific order.
✅ Verification successful
Let me gather more information about the module dependencies.
Let me check one final aspect about the licensing module dependencies.
Module initialization order is correctly implemented
The current order of licensing-related modules in the imports array is appropriate:
LicensingFrameworkModule(comes first)LicenseIssuerModuleLicensingCredentialBasedModule
The modules are independent of each other with no circular dependencies or initialization requirements, as evidenced by their module definitions. The LicensingCredentialBasedModule is particularly lightweight with no imports, making its position in the array non-critical.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for module initialization dependencies
rg "forRoot|forFeature" --type ts | grep -i "licensing"
# Check for any circular dependencies
ast-grep --pattern 'import { $_ } from "@platform/licensing/credential-based/$$$"'
Length of output: 560
Script:
#!/bin/bash
# Check the content of LicensingCredentialBasedModule and its dependencies
ast-grep --pattern 'export class LicensingCredentialBasedModule {
$$$
}'
# Check imports in the account module
cat src/domain/space/account/account.module.ts
# Check other licensing-related imports in the module
rg -l "LicensingCredentialBasedModule" --type ts
Length of output: 3808
Script:
#!/bin/bash
# Check the content of the licensing framework and license issuer modules
cat src/platform/licensing/credential-based/licensing-framework/licensing.framework.module.ts
cat src/platform/licensing/credential-based/license-credential-issuer/license.issuer.module.ts
cat src/platform/licensing/credential-based/licensing-credential-based-entitlements-engine/licensing.credential.based.module.ts
Length of output: 2351
src/domain/space/space/space.module.ts (1)
26-27: LGTM! Verify module dependencies.
The restructuring of licensing modules aligns well with the PR objectives of separating credential-based licensing. The module structure follows NestJS best practices.
Let's verify that all required dependencies are properly imported:
Also applies to: 32-32, 47-47
✅ Verification successful
Import changes are properly integrated across the codebase
The imports of LicensingCredentialBasedModule and LicenseIssuerModule in space.module.ts are correctly referenced by multiple dependent modules and services. The codebase shows consistent usage of these modules across:
- Platform licensing framework (
@platform/licensing/credential-based/*) - Space and Account services
- Admin licensing services
- Bootstrap module
The restructuring maintains proper module dependencies and follows NestJS architectural patterns.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any potential circular dependencies or missing imports
ast-grep --pattern 'import { $_ } from "@platform/licensing/credential-based/$$$"'
Length of output: 84
Script:
#!/bin/bash
# Let's try a different approach to check the imports
rg -l "@platform/licensing/credential-based" --type ts
# Check the content of files that have these imports
rg "@platform/licensing/credential-based" --type ts -A 2 -B 2
Length of output: 35262
src/platform/platform/platform.resolver.fields.ts (1)
16-16: LGTM! Import path updated correctly.
The import path update aligns with the new credential-based licensing structure while maintaining the existing GraphQL resolver functionality.
src/platform/licensing/credential-based/licensing-framework/licensing.framework.service.ts (1)
11-13: LGTM! Import paths updated correctly.
The import path updates align with the new credential-based licensing structure while maintaining proper separation of concerns.
src/domain/space/account/account.service.license.ts (1)
Line range hint 147-151: Consider implementing Wingback subscription handling
The TODO comment indicates pending implementation for Wingback subscription handling. This is a critical part of the PR objectives.
Let's verify if there are any existing Wingback integration patterns in the codebase:
Would you like me to help create a GitHub issue to track the implementation of the Wingback subscription integration?
src/domain/space/space/space.service.license.ts (1)
10-10: Consider using a barrel import for licensing modules
Similar to the account service, the import path could be simplified.
src/platform/admin/licensing/admin.licensing.service.ts (2)
6-6: LGTM: Import path changes align with the new credential-based structure
The updated import paths correctly reflect the new organization of licensing-related modules, improving code organization by separating credential-based licensing components.
Also applies to: 14-14, 16-16
42-44: Verify the enum value changes across the codebase
The change from LicensePlanType to LicensingCredentialBasedPlanType is consistently applied across all methods. However, we should verify that all consumers of these enum values have been updated.
Also applies to: 86-88, 130-132, 173-175
✅ Verification successful
Enum value changes have been consistently updated across the codebase
The verification shows that there are no remaining references to the old LicensePlanType enum, and all usages have been properly updated to use LicensingCredentialBasedPlanType. The new enum is consistently used in both space.service.ts and admin.licensing.service.ts.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining references to the old enum
rg "LicensePlanType\." --type ts
# Search for usage of the new enum to ensure consistency
rg "LicensingCredentialBasedPlanType\." --type ts
Length of output: 1202
src/platform/platform.role/platform.role.service.ts (1)
22-22: LGTM: Consistent credential type updates
The migration from LicenseCredential to LicensingCredentialBasedCredentialType is correctly implemented across role assignment and removal logic.
Also applies to: 102-102, 150-150
src/app.module.ts (2)
89-90: LGTM! Import statements follow NestJS conventions.
The imports are well-organized and follow the established pattern of using absolute paths with aliases.
271-272: LGTM! Module registration follows NestJS best practices.
The new modules are properly integrated into the application's dependency injection system.
src/core/bootstrap/bootstrap.service.ts (1)
60-61: LGTM! Import paths reflect the new licensing structure.
The updated import paths properly reflect the reorganization of licensing components into credential-based modules.
alkemio.yml (1)
88-93: LGTM! Configuration follows security best practices.
The new licensing section:
- Uses environment variables for sensitive values
- Has a safe default (false) for the enabled flag
- Follows the established configuration structure
Let's verify the environment variables are documented:
...ial-based-entitlements-engine/licensing.credential.based.policy.rule.credential.interface.ts
Show resolved
Hide resolved
...ial-based-entitlements-engine/licensing.credential.based.policy.rule.credential.interface.ts
Outdated
Show resolved
Hide resolved
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.spec.ts
Show resolved
Hide resolved
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.spec.ts
Outdated
Show resolved
Hide resolved
src/platform/licensing/wingback-subscription/licensing.wingback.subscription.service.ts
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…k.subscription.service.spec.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
No regression found in API tests, application boots OK, rabbitAI comments addressed / stories raised, unit tests fixed. |
Refactoring + renaming to make clear there are two routes to generating entitlements:
Rational is to separate license entitlements from how they are determined.
Initial adapter + config for wingback added, with types. Two modules:
For testing two mutations added
createCostumermethod exposed viaadminWingbackCreateTestCustomermutation (to be removed later)getEntitlementsmethod exposed viaadminWingbackGetCustomerEntitlementsmutation (to be removed later)Suggest to take this code in + then do remaining work to interface business logic to wingback.
To do:
Summary by CodeRabbit
New Features
LicensingWingbackSubscriptionModuleandWingbackManagerModulefor enhanced licensing functionality.LicensingWingbackSubscriptionServicefor managing customer-related operations.Bug Fixes
Documentation
Chores