Fix PROD issue with CallForPosts contributions failing to load

[bobbykolev]

Summary by CodeRabbit

• Chores
  • Updated the package version to v0.81.2.
• Bug Fixes
  • Enhanced error messaging and data processing for clearer and more reliable feedback.

[coderabbitai]

Walkthrough

This pull request updates the package version in package.json from "0.81.1" to "0.81.2". In addition, it adjusts the useUrlResolver function located in src/main/urlResolver/useUrlResolver.ts by revising the error message to correctly reference the callout set and by changing the logic for extracting contributionId and postId. The extraction now uses the .find() method to retrieve the contribution that contains an associated post.

Changes

File(s)	Change Summary
package.json	Version update from "0.81.1" to "0.81.2".
src/main/urlResolver/useUrlResolver.ts	Updated error message to reference callout set. Revised logic for extracting contributionId and postId by using .find() for contributions.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant U as useUrlResolver
    C->>U: Request URL resolution
    U->>U: Check for callout existence
    alt Callout not found
        U->>C: Throw NotFoundError ("Callout 'X' not found in calloutSet 'Y'")
    else Callout found
        U->>U: Extract contribution using .find() for contribution with a post
        U->>C: Return URL resolution data (contributionId and postId)
    end

Loading

Possibly related PRs

• version bump #6956: Involves a version bump in package.json, which is aligned with the version update in this PR.
• Fix PROD issue with CallForPosts contributions failing to load  #7603: Directly related to modifications in error handling and data extraction logic within useUrlResolver, similar to the changes introduced here.
• new release version 0.75.0 #7058: Contains changes for updating the package version in package.json, corresponding to the version increment in this PR.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab42d31 and 2f16161.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

• package.json (1 hunks)
• src/main/urlResolver/useUrlResolver.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• package.json

🧰 Additional context used

📓 Path-based instructions (1)

src/main/urlResolver/useUrlResolver.ts (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

• We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
• Avoid flagging the absence of local error handling in cases where the global error handler suffices.
• Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

• Not Required: there's a skip
  {
  variables: { templateId: templateId! },
  skip: !templateId,
  }

Check for common security vulnerabilities such as:

• SQL Injection
• XSS (Cross-Site Scripting)
• CSRF (Cross-Site Request Forgery)
• Insecure dependencies
• Sensitive data exposure

🔇 Additional comments (2)

src/main/urlResolver/useUrlResolver.ts (2)

237-237: LGTM! Error message now correctly references the lookup context.

The error message now accurately reflects that the callout lookup is performed within the callout set context.

---

245-247: LGTM! Fixed the contribution lookup logic.

The new implementation correctly handles cases where the first contribution might not have an associated post by explicitly finding a contribution that has a post.

Let's verify the fix by checking for any other similar patterns in the codebase that might need the same update:

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.