Remove location from VC card

[ccanos]

• Removed the location from the UserCard when there's no location
• And set fixed width to the tooltip because UX was weird with these variable cards

[coderabbitai]

Walkthrough

The pull request introduces modifications to two components: ContributorCardSquare and UserCard. In ContributorCardSquare, a new import for gutters is added, and the tooltip content is wrapped in a Box component with a width determined by the gutters function. In the UserCard component, the location rendering is conditionally updated, and the ExpandableCardFooter now has an expandable prop based on the presence of tags.

Changes

File	Change Summary
src/domain/community/contributor/ContributorCardSquare/ContributorCardSquare.tsx	Added gutters import and wrapped tooltip content in Box with width determined by gutters
src/domain/community/user/userCard/UserCard.tsx	Modified location rendering to only show when truthy, updated ExpandableCardFooter with expandable prop based on tags

Possibly related issues

• Remove location from VC card #7285: The changes to the UserCard component could be related to the issue about removing location from the VC card, as the location rendering has been modified to only display when truthy.

Possibly related PRs

• Fix the Host card on the VC profile #7150: Related to user component modifications
• Homepage fixes #7224: Potential translation updates for tooltips
• [Subspace Templates] Update the innovation pack card template icons + clean up #7277: Additional translation file changes
• update contributors image for unauth users and fix styles #7354: Updates to contributors' images and styles

Suggested labels

client

Suggested reviewers

• bobbykolev

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdf70f6 and ea5abea.

📒 Files selected for processing (2)

• src/domain/community/contributor/ContributorCardSquare/ContributorCardSquare.tsx (2 hunks)
• src/domain/community/user/userCard/UserCard.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/domain/community/contributor/ContributorCardSquare/ContributorCardSquare.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

• We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
• Avoid flagging the absence of local error handling in cases where the global error handler suffices.
• Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

• Not Required: there's a skip
  {
  variables: { templateId: templateId! },
  skip: !templateId,
  }

Check for common security vulnerabilities such as:

• SQL Injection
• XSS (Cross-Site Scripting)
• CSRF (Cross-Site Request Forgery)
• Insecure dependencies
• Sensitive data exposure

src/domain/community/user/userCard/UserCard.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:

• We have a global error handler in place. So local try/catch blocks are not required unless they provide value beyond what the global error handler already covers.
• Avoid flagging the absence of local error handling in cases where the global error handler suffices.
• Avoid flagging the absence of logging in cases where the global logger is already in place (graphql usage).

Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:

• Not Required: there's a skip
  {
  variables: { templateId: templateId! },
  skip: !templateId,
  }

Check for common security vulnerabilities such as:

• SQL Injection
• XSS (Cross-Site Scripting)
• CSRF (Cross-Site Request Forgery)
• Insecure dependencies
• Sensitive data exposure

🔇 Additional comments (4)

src/domain/community/user/userCard/UserCard.tsx (2)

105-107: LGTM: Clean implementation of conditional location rendering

The condition correctly handles the case when location is empty, aligning with the PR objective to remove location from VC card.

---

111-115: LGTM: Enhanced footer expandability logic

Good addition of the expandable prop to prevent unnecessary expansion when there are no tags to display.

src/domain/community/contributor/ContributorCardSquare/ContributorCardSquare.tsx (2)

17-17: LGTM: Clean import of grid utility

The gutters utility import follows project conventions and is appropriately used for tooltip sizing.

---

115-127: LGTM: Well-structured tooltip with consistent width

Good use of Box wrapper with gutters to maintain consistent tooltip width. Props are properly passed to UserCard component.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.