Innovation library name changes and 1 fix #7281
Conversation
WalkthroughThis pull request implements extensive updates to translation files across multiple languages for the Alkemio platform. The primary focus is on renaming terms related to "Innovation" to "Template," including the "Innovation Library" being changed to "Template Library" and "Innovation Packs" to "Template Packs." These changes are reflected in various user interface elements, descriptions, and error messages, aiming for consistency in terminology and clarity in user experience. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/core/i18n/de/translation.de.json (1)
Line range hint
1815-1817: Update German library section translationsThe library section in the German translation needs to be updated to use the new "Template" terminology. Please update the following translations:
- "fullName": "Best practices", + "fullName": "Vorlagenbibliothek", - "title": "Innovationsbibliothek auf Alkemio ist hier, um Ihren Weg zu beeinflussen,", + "title": "Die Vorlagenbibliothek auf Alkemio ist hier, um Ihren Weg zum Erfolg zu begleiten", - "subtitle": "Öffnen Sie die Innovationspakete unten, um alle Whiteboard-Templates, Post-Vorlagen und Innovationsströme, die Sie verwenden können, zu erforschen. Wenn Sie mehr über <click>erfahren möchten, klicken Sie hier</click>.", + "subtitle": "Öffnen Sie die Vorlagenpakete unten, um alle Whiteboard-Vorlagen, Post-Vorlagen und Innovationsabläufe zu erkunden, die Sie verwenden können. Wenn Sie mehr darüber <click>erfahren möchten, klicken Sie hier</click>.",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
src/core/apollo/generated/graphql-schema.tsis excluded by!**/generated/**
📒 Files selected for processing (8)
src/core/i18n/bg/translation.bg.json(1 hunks)src/core/i18n/de/translation.de.json(1 hunks)src/core/i18n/en/translation.en.json(6 hunks)src/core/i18n/es/translation.es.json(2 hunks)src/core/i18n/fr/translation.fr.json(1 hunks)src/core/i18n/ua/translation.ua.json(2 hunks)src/domain/InnovationPack/admin/AdminInnovationPackPage.tsx(3 hunks)src/domain/community/contributor/Account/ContributorAccountView.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/domain/community/contributor/Account/ContributorAccountView.tsx
- src/core/i18n/en/translation.en.json
🧰 Additional context used
📓 Path-based instructions (6)
src/domain/InnovationPack/admin/AdminInnovationPackPage.tsx (1)
Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Use the following code guide documentation in the codebase: 'docs/code-guidelines.md'.
Ensure sufficient error handling and logging is present, but note:
- Local
try/catchblocks are not required unless they provide value
beyond what the global error handler already covers. - Avoid flagging the absence of local error handling in cases where the
global error handler suffices. - Avoid flagging the absence of logging in cases where the global logger is
already in place (graphql usage).
Inform about the recommendation of not using non-null assertion,
except on GraphQL queries where the variable is asserted non-null and followed by a
skip: with the same variable.
Examples:
- Not Required: there's a skip
{
variables: { templateId: templateId! },
skip: !templateId,
}
Check for common security vulnerabilities such as:
- SQL Injection
- XSS (Cross-Site Scripting)
- CSRF (Cross-Site Request Forgery)
- Insecure dependencies
- Sensitive data exposure
src/core/i18n/de/translation.de.json (1)
Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/ua/translation.ua.json (1)
Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/fr/translation.fr.json (1)
Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/bg/translation.bg.json (1)
Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
src/core/i18n/es/translation.es.json (1)
Pattern src/**/*.json: Review the JSON files for correct syntax and structure.
Ensure that the configuration and data are accurate and follow the project's standards.
Check for sensitive data exposure and ensure that the data is properly validated.
🔇 Additional comments (9)
src/domain/InnovationPack/admin/AdminInnovationPackPage.tsx (3)
51-51: LGTM! Error message updated correctly.
The error message has been updated to use "Template Pack" consistently with the PR objectives.
61-61: LGTM! Error message updated correctly.
The error message has been updated to use "Template pack" consistently with the PR objectives.
135-135: LGTM! Comment updated correctly.
The comment has been updated to use "Template pack" consistently with the PR objectives.
src/core/i18n/bg/translation.bg.json (1)
2325-2327: LGTM! Translation strings updated correctly.
The translation strings have been updated to use "Template" terminology consistently with the PR objectives.
src/core/i18n/ua/translation.ua.json (2)
1815-1816: LGTM! Translation strings updated correctly.
The translation strings have been updated to use "Template Library" consistently with the PR objectives.
2325-2327: LGTM! Translation strings updated correctly.
The translation strings have been updated to use "Template" terminology consistently with the PR objectives.
src/core/i18n/es/translation.es.json (2)
1815-1817: LGTM! Library terminology changes are consistent
The renaming from "Innovation library" to "Template library" has been correctly implemented in the Spanish translation file. The changes maintain consistency with the English terminology while preserving the meaning in Spanish.
2325-2327: LGTM! Home section library references updated correctly
The library references in the home section have been properly updated to use "Template" terminology instead of "Innovation". The translations are consistent with the overall terminology changes.
src/core/i18n/fr/translation.fr.json (1)
2325-2327: LGTM! The terminology changes are consistent.
The renaming from "Innovation library/packs" to "Template library/packs" has been properly implemented in the French translation file.
There was a problem hiding this comment.
Only the messages in the English file should be updated, the rest of languages should be changed in crowdin, will call you and show you how @DonnaDuiker
|
Closing it as per our conversation |
Describe the background of your pull request
Changing these names:
Innovation library --> Template library
Best Practices (in menu) --> Template library
Innovation pack --> Template pack
As described here: https://github.com/orgs/alkem-io/projects/22/views/5?pane=issue&itemId=89200104&issue=alkem-io%7Cclient-web%7C7265
1 sentence did not make sense anymore after challenge was changed to subspace, as mentioned here: https://github.com/orgs/alkem-io/projects/22/views/5?pane=issue&itemId=88839685&issue=alkem-io%7Cproduct%7C1387
Additional context
Add any other context
Governance
By submitting this pull request I confirm that:
https://github.com/alkem-io/Coordination/blob/master/LICENSE.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation