Update to your pull-request for making es5/require work. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not return with empty legend items to clear old legends
Co-authored-by: Liam Connors <liam@plot.ly>
Co-authored-by: Liam Connors <liam@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Co-authored-by: Alex Johnson <alex@plot.ly>
Fix potential prototype pollution in `expandObjectPaths`
Update Croatian translation with messages and numeric format
Fix potential prototype pollution in `nestedProperty`
reduce flakiness on CI
…e-tick-bug Add switch to specify major/minor in `axes.arrayTicks()`
Fix `upperfence` description
Accept objects for encoded typedarrays in data_array valType
Bump dev deps 2024 01 05
npm audit fix - follow-redirects 1.15.5
I agree with the contributor's choice of dialetc over plotly's default. However, I think adding piece-meal rules to change how stuff is built will ultimately make it more complicated to refactor, maintain, and read in the future. The current dialect of javascript (enforced primarily by the linter at least in the pull-request stage), is limiting and inconvenient. Migrating to a more modern javascript, I believe, requires a broader strategy.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, it seems huge because I also merged the plotly master branch
Hi! This pull request would
a) upgrade
chart2musicso that it supports commonjsb) convert
accessibility.jsto ES5 (since that seems to be there standard, currently).I'm open to moving ES5->ES6 but with these changes it'll just get a green check right away.
I think there is still some UX stuff to consider.