Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop asiofi / asio from FairMQ #4869

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Drop asiofi / asio from FairMQ #4869

merged 1 commit into from
Mar 2, 2023

Conversation

ktf
Copy link
Member

@ktf ktf commented Mar 2, 2023

They are now deprecated and will be removed in 1.5.0.

@ktf ktf requested a review from a team as a code owner March 2, 2023 10:39
@TimoWilken
Copy link
Contributor

Is it worth removing the asiofi and asio recipes from alidist entirely, since they won't be tested by CI after this change and will presumably just become stale? They don't seem to be used by anything other than FairMQ.

@davidrohr
Copy link
Contributor

I think so, and also libfabric should be removed.
I asked 2 weeks ago (on 16th), and said we'd remove it in 2 weeks since noone complains. So I think we cann remove the 3 now.

@dennisklein
Copy link
Contributor

Is it worth removing the asiofi and asio recipes from alidist entirely, since they won't be tested by CI after this change and will presumably just become stale? They don't seem to be used by anything other than FairMQ.

From my point of view, they can go away, perhaps also ofi.sh. Originally, they were all introduced by me, but I have not tracked if anybody else started to depend on them.

@ktf
Copy link
Member Author

ktf commented Mar 2, 2023

No objections to dropping the recipes completely, but let's do that in a separate PR, since this one is already undergoing testing....

@ktf ktf merged commit afa31ac into master Mar 2, 2023
@ktf ktf deleted the ktf-patch-18 branch March 2, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants