Fix linter errors in higher-level packages #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the remaining linter errors in packages that won't cause a rebuild of the entire software stack. Also fix linter warnings in the same packages, as the package hashes will change anyway, and this way the warnings won't suddenly crop up the next time anyone sends a PR including these packages.
This recipe doesn't seem to be working properly, and it has a linter error due to the double `build_requires` key. It's also for an old version, hasn't been touched in almost 7 years, and is not depended upon by any other package, so I assume this is obsolete.
|
fine with me |
ktf
previously approved these changes
Mar 3, 2023
vascobarroso
previously approved these changes
Mar 3, 2023
|
Thanks for the reviews! I'll merge when the CI succeeds. |
vascobarroso
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remaining linter errors in packages that won't cause a rebuild of the entire software stack.
Also fix linter warnings in the same packages, as the package hashes will change anyway, and this way the warnings won't suddenly crop up the next time anyone sends a PR including these packages.
Also delete parquet-cpp recipe; see 0bacb34 for details.
Draft to avoid too many rebuilds in CI.
Needed for #4730.