Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Geant4 recipe to make possible to define an external directory for data sets, plus clean-up: #2765

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

ihrivnac
Copy link
Contributor

  • This PR restores back ca28635
  • Fix setting Geant4 data sets in build environment (failing in the previous version):
    • Removed setting data sets in env: section in geant4.sh
    • Added setting data sets environment via geant4-config in recipes with Geant4 tests
      (aliroot-guntest.sh, o2.sh)

… for data sets, plus clean-up

- restore back commit ca28635
…revious version):

- Removed setting data sets in env: section in geant4.sh
- Added setting data sets environment via geant4-config in recipes woth Geant4 tests
  (aliroot-guntest.sh, o2.sh)
@ihrivnac ihrivnac requested a review from a team as a code owner January 14, 2021 10:25
@ihrivnac ihrivnac requested review from ktf, rdivia and sawenzel and removed request for rdivia January 15, 2021 11:34
@ihrivnac
Copy link
Contributor Author

@ktf, @sawenzel , can you approve ? Thank you.

@ihrivnac
Copy link
Contributor Author

@ktf , can you merge ? Thank you.

@sawenzel
Copy link
Collaborator

@ktf: Shouldn't simulation experts be able to merge this as per CODEOWNERS? The button is not activated.

@sawenzel sawenzel merged commit 9da42b9 into alisw:master Jan 27, 2021
@ktf
Copy link
Member

ktf commented Jan 27, 2021

@sawenzel the issue was that since o2.sh and aliroot-gun.sh were modified, it required a review from alisw@infrastructure-admins. I added alisw/pdp-experts for all the "mostly PDP" things, so next time your review should be enough. Of course I could have added you to alisw@infrastructure-admin (or you can add yourself, since you should be a global admin), however I think it's better if we keep infrastructure-admin separate, so that we have some better chance to notice new recipes / recipes without a proper owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants